Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model and README Enhancement] Glass Bangle Defects Detection #643

Merged

Conversation

Arihant-Bhandari
Copy link
Contributor

Pull Request for DL-Simplified 💡

Issue Title : #589 [Model and README Enhancement] Glass Bangle Defects Detection

Closes: #589 [Model and README Enhancement] Glass Bangle Defects Detection

Describe the add-ons or changes you've made 📃

Added a CNN model based on Keras, Added a CNN model with Attention mechanism, enhanced README.md, added necessary images and doc updates

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

CNN-Keras

Accuracy: 0.8148148148148148
Precision: 0.8084067536295051
Recall: 0.7887957990213629
F1 Score: 0.7965163842984425

Loss: 0.5013639330863953

CNN with Attention mechanism

Loss:

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @Arihant-Bhandari :)

@Arihant-Bhandari
Copy link
Contributor Author

hi @abhisheks008 , due to certain circumstances in my college, my exams have been postponed and hence, i have started working on this issue again. this is part one of my issue, CNN using Keras, please see this, i will update CNN with attention soon and then redo README as well.

@abhisheks008
Copy link
Owner

One more thing, you have used ResNet and GoogleNet again? The models were already implemented.

@abhisheks008 abhisheks008 added Status: Requested Changes Changes requested. gssoc Girlscript Summer of Code 2024 labels May 27, 2024
@Arihant-Bhandari
Copy link
Contributor Author

no i havent i have added on to the previous work, at the bottom, the previous owner's work has been kept as is.

@Arihant-Bhandari
Copy link
Contributor Author

hi @abhisheks008 i have added all things necessary for this project. please check and if there are any suggestions or changes to be done, let me know, i would be glad to do them. thank you for the oppurtunity,

@abhisheks008
Copy link
Owner

Can you rename the project folder as Glass Bangle Defects Detection by removing the hyphens.

@Arihant-Bhandari
Copy link
Contributor Author

Arihant-Bhandari commented May 27, 2024

Sure , should I be changing the name of the project itself and so on or just the .ipynb file ?

@Arihant-Bhandari
Copy link
Contributor Author

Also , @abhisheks008 I wanted to know how we can contribute an entire project to the repo ? Like following similar procedures for enhancements would be fine right ? I had a project in mind which can be considered novel.

If yes , I would like to put this as my next issue.

@abhisheks008
Copy link
Owner

Sure , should I be changing the name of the project itself and so on or just the .ipynb file ?

Project folder name

@abhisheks008
Copy link
Owner

Also , @abhisheks008 I wanted to know how we can contribute an entire project to the repo ? Like following similar procedures for enhancements would be fine right ? I had a project in mind which can be considered novel.

If yes , I would like to put this as my next issue.

Go ahead. Follow the issue template and create your issue.

@Arihant-Bhandari Arihant-Bhandari force-pushed the enhance_bangle_defect branch from cd434eb to d0585fc Compare May 27, 2024 19:45
@Arihant-Bhandari
Copy link
Contributor Author

hi @abhisheks008 , i have done things requested as much as i can, unfortunately i couldnt change the folder name since i am on a sparse checkout of this repo, so only the folder i am working on is displayed at my end and sparse checkout has had me in a twist with renaming the folder , i will try my best to do so but the files are ready to be pushed for issue completion.

@Arihant-Bhandari
Copy link
Contributor Author

Arihant-Bhandari commented May 27, 2024

@abhisheks008 hi, i have tweaked the folder name as required from GitHub VSC , pls check and if there are any suggestion i would be glad to make necessary changes. thank you for your time and patience.

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhisheks008 abhisheks008 added Status: Approved Approved PR by the PA. level 2 Level 2 for GSSOC and removed Status: Requested Changes Changes requested. labels May 28, 2024
@abhisheks008 abhisheks008 merged commit ea49bfd into abhisheks008:main May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Girlscript Summer of Code 2024 level 2 Level 2 for GSSOC Points Updated Status: Approved Approved PR by the PA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Model and README Enhancement] Glass Bangle Defects Detection
2 participants