-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model and README Enhancement] Glass Bangle Defects Detection #643
[Model and README Enhancement] Glass Bangle Defects Detection #643
Conversation
Our team will soon review your PR. Thanks @Arihant-Bhandari :) |
hi @abhisheks008 , due to certain circumstances in my college, my exams have been postponed and hence, i have started working on this issue again. this is part one of my issue, CNN using Keras, please see this, i will update CNN with attention soon and then redo README as well. |
One more thing, you have used ResNet and GoogleNet again? The models were already implemented. |
no i havent i have added on to the previous work, at the bottom, the previous owner's work has been kept as is. |
hi @abhisheks008 i have added all things necessary for this project. please check and if there are any suggestions or changes to be done, let me know, i would be glad to do them. thank you for the oppurtunity, |
Can you rename the project folder as |
Sure , should I be changing the name of the project itself and so on or just the .ipynb file ? |
Also , @abhisheks008 I wanted to know how we can contribute an entire project to the repo ? Like following similar procedures for enhancements would be fine right ? I had a project in mind which can be considered novel. If yes , I would like to put this as my next issue. |
Project folder name |
Go ahead. Follow the issue template and create your issue. |
…ssary images and text in README.md
cd434eb
to
d0585fc
Compare
hi @abhisheks008 , i have done things requested as much as i can, unfortunately i couldnt change the folder name since i am on a sparse checkout of this repo, so only the folder i am working on is displayed at my end and sparse checkout has had me in a twist with renaming the folder , i will try my best to do so but the files are ready to be pushed for issue completion. |
@abhisheks008 hi, i have tweaked the folder name as required from GitHub VSC , pls check and if there are any suggestion i would be glad to make necessary changes. thank you for your time and patience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved @Arihant-Bhandari
Pull Request for DL-Simplified 💡
Issue Title : #589 [Model and README Enhancement] Glass Bangle Defects Detection
Closes: #589 [Model and README Enhancement] Glass Bangle Defects Detection
Describe the add-ons or changes you've made 📃
Added a CNN model based on Keras, Added a CNN model with Attention mechanism, enhanced README.md, added necessary images and doc updates
Type of change ☑️
What sort of change have you made:
How Has This Been Tested? ⚙️
CNN-Keras
Accuracy: 0.8148148148148148
Precision: 0.8084067536295051
Recall: 0.7887957990213629
F1 Score: 0.7965163842984425
Loss: 0.5013639330863953
CNN with Attention mechanism
Loss:
Checklist: ☑️