Replace "-sh", "-c" with "env", "-S"

[n-connect]

Trying to get a rid of the sh -c wrappers within hyprland session:

• testing a patched hyprland since 0.47.2 -> works #9403
• nwg-drawer, nwg-menu already got rid of the sh -c wrappings
• now doing the same env -S "trick" with walker as my favorite app runner (and more).

As a first step - only the interactions.go file modified and tested - I'm using daily always.. I'll need to check and test the others: events, plugins, ai, clipboard, theme, ui.

Running programs, wayland or xwayland works (Through hyprland-polkit-agent, which adds its own /bin/sh wrap, :) )

[abenz1267]

Hello,

thank you for your contribution. I'm wondering:

would it be better to let this be defined via cfg?

[n-connect]

@abenz1267

would it be better to let this be defined via cfg?

Thanks, for your quick answer. And thanks for walker itself, really nice!

Of course cfg definition would give a certain flexibility. It would be good to know, why they are there in the first place? So maybe there's no big need there at the first place.
Is it fulfills some deliberate function? Or "just" preserving and passing through the existing environment for starting a new binary/process/GUI app?
If the former, it should be cfg defined. If the latter, I think its just makes walker more "tidy". And stop adding to the look "this linux desktop it got hacked" :)

[abenz1267]

Pretty sure I just added it for preserving existing env-vars etc when launching things.

[n-connect]

Great, would you test it yourself at this stage? The fact it is working for me just one positive sign.

Also I need to learn walker, as I literally use it for launching stuff, calc stuff checking currency rates and initiate google(web) search. Just like in macOS's Spotlight I'm working with. Aaand now I just saw it no longer shows in hint the currency value, but websearch only. :)

[abenz1267]

Could you replace every sh -c call? I'd then merge and push a release as soon as the other PR is done.

[n-connect]

Sure, all of them done.
Would give me some pointers on what's the sortest way testing the addtional ones out? Like translators or ai module? Read the wiki I'll get an API key? :D
I'll test clipboard in the meaning time.

Also, I'm not really familiar with go, is there a way to make the built walker binary smaller?

[n-connect]

Clipboard, translator, calc module works.

ps auxf | grep walker
user     290965  1.6  1.8 3685428 140504 pts/2  Sl+  23:19   0:00  |   \_ walker --gapplication-service
user     291115  0.0  0.0   2728  1636 pts/2    S+   23:19   0:00  |       \_ wl-paste --watch walker --update-clipboard
user     291514  0.0  0.0   9472  2248 pts/5    S+   23:19   0:00      \_ grep walker

I've just realized I got a bunch of Gtk error messages if I run walker in CLI directly, without its "service mode pair" as I usually do. By testing clipboard, I've got the same Gtk error messages, but with walker service in another cli walker --gapplication-service. Up until that service runs, no other walker gives error messages. What should I do to got a rid of the Gtk error messages?
walker_gtk_errors.txt