Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit test for the n310 #6

Open
wants to merge 2 commits into
base: unit_tests
Choose a base branch
from
Open

unit test for the n310 #6

wants to merge 2 commits into from

Conversation

Ilagas
Copy link

@Ilagas Ilagas commented May 31, 2021

Unit tests for the sara n310. Shows basic functionality of the zephyr unit test system for zephyr.

@Ilagas
Copy link
Author

Ilagas commented May 31, 2021

Since i have recreated this pull request; this is what Noelle originally commented:

General review:

  • check if all files (also outside of the n310 driver files) should be in the PR (did the tests work for all boards you have added overlays for?)
  • please remove the commented code (only code that works / has added value should be in the PR)
  • please add some more information in the README file (what does the test do? example test results + how to run it etc)
  • add some commenting in the test file, is there specific information that is good to know?

@abelNoelleC
Copy link

As mentioned by @Ilagas through Slack: This PR doesn't work for the changes in #8 . So after that has been merged this will have to be adapted

abelkarapatis
abelkarapatis reviewed Jun 17, 2021
View reviewed changes
tests/drivers/modem/ublox_sara_n310/src/n310_stub.c
printk("cmd_handler_process");
}

int modem_cmd_send(struct modem_iface *iface, struct modem_cmd_handler *handler,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is the biggest change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelkarapatis abelkarapatis abelkarapatis left review comments

Assignees
No one assigned
Labels
area: Documentation area: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ilagas @abelNoelleC @abelkarapatis