Skip to content

Commit

Permalink
Minor update of CONTRIBUTING
Browse files Browse the repository at this point in the history
  • Loading branch information
Alex Westergaard committed Apr 4, 2023
1 parent c144e0d commit c9902a4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# Contribute

Thank you for being interesting in this package and wanting to contribute to it.
Thank you for being interested in this package and wanting to contribute to it.

## Coding

New code should be introduced to the codebase through issues that specify what you are trying to accomplish.
I understand that sometimes you need to add/update/delete code otherwhere in the codebase to achieve this goal.
This is why my test always merges master in to ensure that your code stays functional/executable during development.

Please adhere these pointers:
**Please adhere these pointers:**
* Support selected PHP Versions | Ref: [Master/Composer.json](https://github.com/AlexWestergaard/php-ga4/blob/master/composer.json)
* Pass current tests without modification; unless clearly explaining why the change is necessary/required | `> vendor/bin/phpunit`
* PHPUnit tests should confidently ensure that code doesn't fail/error in unwated ways (eg. E_WARNINGS or missing paranthesis)
Expand Down

0 comments on commit c9902a4

Please sign in to comment.