leaflet 0.7.7 -> 1.9.4 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zverik
requested changes
Jun 17, 2024
www/script.js
Outdated
| if (init_l0_map.force || !map.restoreView()) { | ||
| map.setView(init_l0_map.center.split(', '), init_l0_map.zoom); | ||
| } | ||
|
|
||
| L.tileLayer('https://tile.openstreetmap.org/{z}/{x}/{y}.png', | ||
| { attribution: 'Map © <a href="https://www.openstreetmap.org">OpenStreetMap contributors</a>' }).addTo(map); | ||
| { attribution: 'Map © <a href="https://www.openstreetmap.org">OpenStreetMap contributors</a>' }).addTo(map); | ||
| L.control.attribution({ prefix: '<a href="https://leafletjs.com/">Leaflet</a>' }).addTo(map); |
There was a problem hiding this comment.
I don't think we need this Leaflet attribution. The map is pretty small as it is, and it's not commonly added.
There was a problem hiding this comment.
Makes sense. Removed now
| @@ -4,8 +4,8 @@ | |||
| <title><?=_('Level0 OpenStreetMap Editor') ?></title> | |||
| <meta charset="utf-8"> | |||
| <meta name="generator" content="<?=GENERATOR ?>"> | |||
| <link rel="stylesheet" href="https://unpkg.com/leaflet@0.7.7/dist/leaflet.css" /> | |||
| <script src="https://unpkg.com/leaflet@0.7.7/dist/leaflet.js"></script> | |||
| <link rel="stylesheet" href="https://unpkg.com/leaflet@1.9.4/dist/leaflet.css" integrity="sha256-p4NxAoJBhIIN+hmNHrzRCf9tD/miZyoHS5obTRR9BMY=" crossorigin="" /> | |||
There was a problem hiding this comment.
Do those integrity and crossorigin things actually work? My vim editor highlights those as warnings.
There was a problem hiding this comment.
It works. Change the integrity hash and the script will refuse to load. https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.7.7 was released in year 2015. I expected more changes were needed but it's incredible backward compatible and everything still works. Minimum browser requirement is now MSIE11 but that's the same as the main openstreetmap.org website.