Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix container and image issues #26

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Fix container and image issues #26

merged 2 commits into from
Jan 28, 2025

Conversation

YanzhaoW
Copy link
Owner

Describe your proposal.

Mention any issue this PR is resolved or is related to.


Checklist:

Copy link

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v18.1.3) reports: 4 concern(s)
  • neuland/application/R3BNeulandAnalysisApp.h:115:48: warning: [misc-include-cleaner]

    no header providing "std::vector" is directly included

        5 |         void ParseApplicationOption(const std::vector<std::string>& filename) override
          |                                                ^
  • neuland/application/R3BNeulandApp.cxx:3:1: warning: [misc-include-cleaner]

    included header CLI.hpp is not used directly

        3 | #include <CLI/CLI.hpp>
          | ^~~~~~~~~~~~~~~~~~~~~~
        4 | #include <FairParRootFileIo.h>
  • neuland/application/R3BNeulandApp.cxx:99:54: warning: [misc-include-cleaner]

    no header providing "std::vector" is directly included

       99 |         auto use_config_callback = [this](const std::vector<std::string>& filename)
          |                                                      ^
  • neuland/application/R3BNeulandSimApp.h:71:48: warning: [misc-include-cleaner]

    no header providing "std::vector" is directly included

        5 |         void ParseApplicationOption(const std::vector<std::string>& filename) override
          |                                                ^

Have any feedback or feature suggestions? Share it here.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v18.1.3

Only 2 out of 4 clang-tidy concerns fit within this pull request's diff.

Click here for the full clang-tidy patch
diff --git a/neuland/application/R3BNeulandAnalysisApp.h b/neuland/application/R3BNeulandAnalysisApp.h
index 83734f4..712c772 100644
--- a/neuland/application/R3BNeulandAnalysisApp.h
+++ b/neuland/application/R3BNeulandAnalysisApp.h
@@ -4,0 +5 @@
+#include <vector>
diff --git a/neuland/application/R3BNeulandApp.cxx b/neuland/application/R3BNeulandApp.cxx
index 823db98..7440ebd 100644
--- a/neuland/application/R3BNeulandApp.cxx
+++ b/neuland/application/R3BNeulandApp.cxx
@@ -3 +2,0 @@
-#include <CLI/CLI.hpp>
diff --git a/neuland/application/R3BNeulandSimApp.h b/neuland/application/R3BNeulandSimApp.h
index d89569f..5bd2c0f 100644
--- a/neuland/application/R3BNeulandSimApp.h
+++ b/neuland/application/R3BNeulandSimApp.h
@@ -4,0 +5 @@
+#include <vector>

Used clang-format v18.1.3

No concerns from clang-format.

Have any feedback or feature suggestions? Share it here.

#include "R3BNeulandApp.h"
#include "R3BFileSource2.h"
#include <CLI/CLI.hpp>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy diagnostics

Please remove the line(s)

  • 3

@@ -96,7 +96,7 @@ namespace R3B::Neuland
dump_json_filename_ = filename;
};

auto use_config_callback = [this](const std::string& filename)
auto use_config_callback = [this](const std::vector<std::string>& filename)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy diagnostic

neuland/application/R3BNeulandApp.cxx:99:54: warning: [misc-include-cleaner]

no header providing "std::vector" is directly included

   99 |         auto use_config_callback = [this](const std::vector<std::string>& filename)
      |                                                      ^

@YanzhaoW YanzhaoW merged commit cbf8045 into edwin_dev Jan 28, 2025
4 of 5 checks passed
@YanzhaoW YanzhaoW deleted the edwin_fix_container branch January 29, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant