-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix container and image issues #26
Conversation
Cpp-Linter Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cpp-linter Review
Used clang-tidy v18.1.3
Only 2 out of 4 clang-tidy concerns fit within this pull request's diff.
Click here for the full clang-tidy patch
diff --git a/neuland/application/R3BNeulandAnalysisApp.h b/neuland/application/R3BNeulandAnalysisApp.h
index 83734f4..712c772 100644
--- a/neuland/application/R3BNeulandAnalysisApp.h
+++ b/neuland/application/R3BNeulandAnalysisApp.h
@@ -4,0 +5 @@
+#include <vector>
diff --git a/neuland/application/R3BNeulandApp.cxx b/neuland/application/R3BNeulandApp.cxx
index 823db98..7440ebd 100644
--- a/neuland/application/R3BNeulandApp.cxx
+++ b/neuland/application/R3BNeulandApp.cxx
@@ -3 +2,0 @@
-#include <CLI/CLI.hpp>
diff --git a/neuland/application/R3BNeulandSimApp.h b/neuland/application/R3BNeulandSimApp.h
index d89569f..5bd2c0f 100644
--- a/neuland/application/R3BNeulandSimApp.h
+++ b/neuland/application/R3BNeulandSimApp.h
@@ -4,0 +5 @@
+#include <vector>
Used clang-format v18.1.3
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
#include "R3BNeulandApp.h" | ||
#include "R3BFileSource2.h" | ||
#include <CLI/CLI.hpp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy diagnostics
- included header CLI.hpp is not used directly [misc-include-cleaner]
Please remove the line(s)
- 3
@@ -96,7 +96,7 @@ namespace R3B::Neuland | |||
dump_json_filename_ = filename; | |||
}; | |||
|
|||
auto use_config_callback = [this](const std::string& filename) | |||
auto use_config_callback = [this](const std::vector<std::string>& filename) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy diagnostic
neuland/application/R3BNeulandApp.cxx:99:54: warning: [misc-include-cleaner]
no header providing "std::vector" is directly included
99 | auto use_config_callback = [this](const std::vector<std::string>& filename)
| ^
Describe your proposal.
Mention any issue this PR is resolved or is related to.
Checklist:
dev
branch