Release exported headers to include/aiebu #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix implementaton to prefix public exported header include with `aiebu/`. Adjust include search path for implementation code. End-user applications should adjust include search path as well but for the time being exported headers remain in legacy locations and are released to legacy location as well. Signed-off-by: Soren Soe <2106410+stsoe@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,4 +1,4 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| // Copyright (C) 2025, Advanced Micro Devices, Inc. All rights reserved. | |||
| #pragma message("please replace src/cpp/aiebu/src/include/aiebu.h with src/cpp/include/aiebu/aiebu.h") | |||
| #pragma message("Please replace inclusion of include/aiebu.h with include/aiebu/aiebu.h") | |||
There was a problem hiding this comment.
warning: Please replace inclusion of include/aiebu.h with include/aiebu/aiebu.h [clang-diagnostic-#pragma-messages]
#pragma message("Please replace inclusion of include/aiebu.h with include/aiebu/aiebu.h")
^| @@ -1,4 +1,4 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| // Copyright (C) 2025, Advanced Micro Devices, Inc. All rights reserved. | |||
| #pragma message("please replace src/cpp/aiebu/src/include/aiebu_assembler.h with src/cpp/include/aiebu/aiebu_assembler.h") | |||
| #pragma message("Please replace inclusion of include/aiebu_assembler.h with include/aiebu/aiebu_assembler.h") | |||
There was a problem hiding this comment.
warning: Please replace inclusion of include/aiebu_assembler.h with include/aiebu/aiebu_assembler.h [clang-diagnostic-#pragma-messages]
#pragma message("Please replace inclusion of include/aiebu_assembler.h with include/aiebu/aiebu_assembler.h")
^| @@ -1,4 +1,4 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| // Copyright (C) 2025, Advanced Micro Devices, Inc. All rights reserved. | |||
| #pragma message("please replace src/cpp/aiebu/src/include/aiebu_error.h with src/cpp/include/aiebu/aiebu_error.h") | |||
| #pragma message("Please replace inclusion of include/aiebu_error.h with include/aiebu/aiebu_error.h") | |||
There was a problem hiding this comment.
warning: Please replace inclusion of include/aiebu_error.h with include/aiebu/aiebu_error.h [clang-diagnostic-#pragma-messages]
#pragma message("Please replace inclusion of include/aiebu_error.h with include/aiebu/aiebu_error.h")
^| @@ -0,0 +1,4 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| // Copyright (C) 2025, Advanced Micro Devices, Inc. All rights reserved. | |||
| #pragma message("Please replace inclusion of aiebu.h with aiebu/aiebu.h") | |||
There was a problem hiding this comment.
warning: Please replace inclusion of aiebu.h with aiebu/aiebu.h [clang-diagnostic-#pragma-messages]
#pragma message("Please replace inclusion of aiebu.h with aiebu/aiebu.h")
^| @@ -0,0 +1,4 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| // Copyright (C) 2025, Advanced Micro Devices, Inc. All rights reserved. | |||
| #pragma message("Please replace inclusion of aiebu_assembler.h with aiebu/aiebu_assembler.h") | |||
There was a problem hiding this comment.
warning: Please replace inclusion of aiebu_assembler.h with aiebu/aiebu_assembler.h [clang-diagnostic-#pragma-messages]
#pragma message("Please replace inclusion of aiebu_assembler.h with aiebu/aiebu_assembler.h")
^| @@ -0,0 +1,4 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| // Copyright (C) 2025, Advanced Micro Devices, Inc. All rights reserved. | |||
| #pragma message("Please replace inclusion of aiebu_error.h with aiebu/aiebu_error.h") | |||
There was a problem hiding this comment.
warning: Please replace inclusion of aiebu_error.h with aiebu/aiebu_error.h [clang-diagnostic-#pragma-messages]
#pragma message("Please replace inclusion of aiebu_error.h with aiebu/aiebu_error.h")
^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exported API header files are released to
include/aiebu/*.hand are to be included using#include <aiebu/zzz.h>.This allows aiebu headers to be installed under a shared include directory within polluting top-level include. This is similar to how XRT headers and many other project headers are installed.
Fix implementation to prefix public exported header include with
aiebu/. Adjust include search path for implementation code.End-user applications should adjust include search path as well but for the time being wrapper headers are released to legacy location while redirecting to new location with a warning.