feat: remove assert library as a testing dep
#2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we have 5 testing library dependencies. This eliminates `assert`. `jest`, `jasmine`, `chai` and `karma` are the remaining ones.
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: assert@2.1.0 |
ckniffen
force-pushed
the
feature/remove-all-assert-references
branch
from
1d2e2da to
4c61f54
Compare
mvadari
reviewed
Nov 7, 2023
Chai is used in way more places. The goal should be to remove chai too. This was just a step toward that. |
jonathanlei
approved these changes
Nov 8, 2023
khancode
approved these changes
Nov 8, 2023
ckniffen
added a commit
that referenced
this pull request
Nov 30, 2023
Right now we have 5 testing library dependencies. This eliminates `assert`. `jest`, `jasmine`, `chai` and `karma` are the remaining ones.
ckniffen
added a commit
that referenced
this pull request
Dec 4, 2023
Right now we have 5 testing library dependencies. This eliminates `assert`. `jest`, `jasmine`, `chai` and `karma` are the remaining ones.
ckniffen
added a commit
that referenced
this pull request
Feb 1, 2024
Right now we have 5 testing library dependencies. This eliminates `assert`. `jest`, `jasmine`, `chai` and `karma` are the remaining ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Right now we have 5 testing library dependencies. This eliminates
assert.jest,jasmine,chaiandkarmaare the remaining ones.Type of Change