Community page #2262

AKCodez · 2023-11-14T01:17:00Z

No description provided.

…styling, changes table logic and rm animation

github-actions · 2023-11-14T01:30:20Z

Link check report. 554131 links checked.
6 broken links found:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/community-page/

Style Report

github-actions · 2023-11-14T01:33:17Z

Link check report. 554131 links checked.
6 broken links found:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/community-page/

Style Report

github-actions · 2023-11-14T14:52:09Z

Link check report. 554131 links checked.
6 broken links found:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/community-page/

Style Report

github-actions · 2023-11-15T00:30:39Z

Link check report. 554131 links checked.
6 broken links found:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/community-page/

Style Report

github-actions · 2023-11-16T15:31:36Z

Link check report. 554131 links checked.
6 broken links found:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/community-page/

Style Report

github-actions · 2023-11-16T15:36:52Z

Link check report. 554129 links checked.
6 broken links found:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/community-page/

Style Report

github-actions · 2023-11-16T21:33:44Z

Link check report. 554129 links checked.
6 broken links found:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/community-page/

Style Report

github-actions · 2023-11-16T22:02:57Z

Link check report. 554129 links checked.
6 broken links found:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/community-page/

Style Report

github-actions · 2023-11-20T14:41:27Z

Link check report. 554129 links checked.
6 broken links found:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/community-page/

Style Report

template/page-community.html.jinja

github-actions · 2023-12-07T14:05:18Z

Link check report. 560376 links checked.
6 broken links found:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/community-page/

Style Report

github-actions · 2023-12-07T14:10:41Z

Link check report. 560376 links checked.
6 broken links found:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:
File: out/ja/contribute.html Link:

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/community-page/

Style Report

github-actions · 2023-12-07T14:35:18Z

Link check report. 560370 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/community-page/

Style Report

github-actions · 2023-12-07T14:44:50Z

Link check report. 560370 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/community-page/

Style Report

github-actions · 2023-12-08T20:05:47Z

Link check report. 579172 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/community-page/

Style Report

github-actions · 2023-12-08T20:33:53Z

Link check report. 579172 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/community-page/

Style Report

mDuo13

Still a couple fixes that need to go in before we should merge this.

mDuo13 · 2023-12-08T23:15:18Z

template/page-community.html.jinja

+<script type="text/javascript">
+document.addEventListener("DOMContentLoaded", function() {
+const events = [
+  { "name": _("New Horizon: Innovate Without Limits: New Horizons Await"),      


The _(...) function for translation doesn't work in this context. You can use it in {% set ... %} blocks which are handled by the Jinja preprocessor (which performs translation at build time) but you can't just use it in client-side JavaScript. The page is throwing an error in the browser console about _ being undefined because of this.

One workaround is to wrap the entire events array here in {{ ... }} which evaluates it as Jinja syntax first, which will do translation and output a dictionary which happens to be compatible with JS syntax… as long as you consistently quote the keys (i.e. the unquoted key literals on lines 291–324 throw an error).

Another problem confounding this is that you have the event details defined in two places and this one is (currently) not being used, the one in contribute-carousel.js is. It's possible to work around that and make it use the translatable one from this file. But you have to do all of the following:

remove the events definition from contribute-carousel.js

use var instead of const

move the script tag for contribute-carousel.js below the one that defines events

plus fix the things with translatability I mentioned in the previous paragraph.

Since that's complicated, I've pushed a commit ( 1e6c237 ) that does all of that. But you probably want to look at the updated events list and confirm that it works.

template/page-community.html.jinja

github-actions · 2023-12-08T23:28:50Z

Link check report. 579172 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/community-page/

Style Report

Co-authored-by: Rome Reginelli <rome@ripple.com>

github-actions · 2023-12-09T14:22:02Z

Link check report. 579172 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/community-page/

Style Report

github-actions · 2023-12-12T00:57:48Z

Link check report. 579093 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/community-page/

Style Report

AKCodez added 9 commits October 25, 2023 11:49

base for new community page

116748f

adds lg version of community page

8e9f95b

adds light mode icons and styles

3c58d03

adds more light mode styles and overrides

fecdb5d

adds silky smooth animation to carousel

ca53c6e

Merge remote-tracking branch 'origin' into community-page

f80409d

Merge remote-tracking branch 'origin' into community-page

3185a70

adds logic for countdown, adds background images, updates light mode …

db3da24

…styling, changes table logic and rm animation

rm non needed lotti json's

5626ef9

rm non needed script

f9f5fca

Merge remote-tracking branch 'origin' into community-page

39bc5cf

AKCodez added 2 commits November 16, 2023 07:18

qa updates

b3893ce

adds typeform

0cfa92f

more qa changes

b10e10f

adds translation tags to all text

b608d04

adds new logic for upcoming events, bases it off start date

cb1b811

AKCodez added 2 commits November 22, 2023 07:32

final QA changes

e19f58b

merge w master

2c20a07

AKCodez requested review from intelliot, mDuo13 and amarantha-k November 22, 2023 15:33

tequdev reviewed Dec 5, 2023

View reviewed changes

template/page-community.html.jinja Outdated Show resolved Hide resolved

intelliot removed their request for review December 6, 2023 06:01

AKCodez added 3 commits December 7, 2023 05:50

Merge remote-tracking branch 'origin' into community-page

8ca497e

change ic png filenames and ref to all lowercase

3fe42c7

rm empty src tag

ad2ed9b

AKCodez added 2 commits December 7, 2023 06:22

variable name changes, adds translation wrapper, qa changes

33f1eba

replace png to with svg

396cbfc

AKCodez requested a review from mDuo13 December 7, 2023 14:33

AKCodez requested a review from tequdev December 7, 2023 14:36

adds new svgs for bg images

eafbabe

Fix asset filename casing

d234faf

Fix translatability of community events carousel

1e6c237

mDuo13 requested changes Dec 8, 2023

View reviewed changes

mDuo13 added needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site web dev Styles, templates, or other technologies for how the site is built & presented labels Dec 8, 2023

Update template/page-community.html.jinja

07de53f

Co-authored-by: Rome Reginelli <rome@ripple.com>

adds new color code for com card link

1092ae1

mDuo13 approved these changes Dec 12, 2023

View reviewed changes

mDuo13 merged commit 1d570e3 into master Dec 12, 2023
3 checks passed

mDuo13 deleted the community-page branch December 12, 2023 01:37

tequdev removed the needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site label Jul 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Community page #2262

Community page #2262

AKCodez commented Nov 14, 2023

github-actions bot commented Nov 14, 2023

github-actions bot commented Nov 14, 2023

github-actions bot commented Nov 14, 2023

github-actions bot commented Nov 15, 2023

github-actions bot commented Nov 16, 2023

github-actions bot commented Nov 16, 2023

github-actions bot commented Nov 16, 2023

github-actions bot commented Nov 16, 2023

github-actions bot commented Nov 20, 2023

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 8, 2023

github-actions bot commented Dec 8, 2023

mDuo13 left a comment

mDuo13 Dec 8, 2023

github-actions bot commented Dec 8, 2023

github-actions bot commented Dec 9, 2023

github-actions bot commented Dec 12, 2023

Community page #2262

Community page #2262

Conversation

AKCodez commented Nov 14, 2023

github-actions bot commented Nov 14, 2023

github-actions bot commented Nov 14, 2023

github-actions bot commented Nov 14, 2023

github-actions bot commented Nov 15, 2023

github-actions bot commented Nov 16, 2023

github-actions bot commented Nov 16, 2023

github-actions bot commented Nov 16, 2023

github-actions bot commented Nov 16, 2023

github-actions bot commented Nov 20, 2023

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 8, 2023

github-actions bot commented Dec 8, 2023

mDuo13 left a comment

Choose a reason for hiding this comment

mDuo13 Dec 8, 2023

Choose a reason for hiding this comment

github-actions bot commented Dec 8, 2023

github-actions bot commented Dec 9, 2023

github-actions bot commented Dec 12, 2023