Improve timeline scroll behavior and fix non visible date on load #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eline-display-for-december
|
Build succeeded and deployed at https://prism-1433.surge.sh |
added 3 commits
February 17, 2025 14:17
…ssh://github.com/WFP-VAM/prism-app into aa-storm-feature/fix-timeline-display-for-december
Max-Z80
commented
Feb 17, 2025
frontend/src/components/MapView/DateSelector/TimelineItems/TimelineLabel/index.tsx
Outdated
Show resolved
Hide resolved
ericboucher
changed the title
|
Thanks @Max-Z80 for this fix! I noticed it before but didn't manage to create an issue. Why are we trying to merge it in the AA storm feature branch instead of main? |
|
@wadhwamatic we're merging to AAStorm to avoid merge conflicts and make sure this is working as expected for AA. But if we'd like to have it sooner we can point it to main. I think AA is almost ready though so not sure it's needed. Up to you :) |
ericboucher
approved these changes
Feb 19, 2025
ericboucher
deleted the
aa-storm-feature/fix-timeline-display-for-december
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix the display of the timeline for months which require an offset to the right of the timeline such as december
How to test the feature:
Checklist - did you ...
Test your changes with
REACT_APP_COUNTRY=rbd yarn startREACT_APP_COUNTRY=cambodia yarn startREACT_APP_COUNTRY=mozambique yarn startScreenshot/video of feature: