-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vmcluster: improve components readiness check #1907
Conversation
func25
commented
Jan 8, 2025
•
edited by Haleygo
Loading
edited by Haleygo
- Remove vmstorage liveness probe, as vminsert already handles routing and retries, while liveness probes can inadvertently introduce delays, DNS instability, and unnecessary disruptions.
- Reduce the default readiness probe interval to 5s (was 15s) and the failure threshold to 10 (was 3).
- Add a default minReadySeconds for vmstorage, to help stabilizing service during rollout.
Could you also help adjust the values for other components like vminsert, vmselect, and vmauth? 15s seems too long for all of them. helm-charts/charts/victoria-metrics-cluster/values.yaml Lines 107 to 114 in 499e4cd
helm-charts/charts/victoria-metrics-cluster/values.yaml Lines 386 to 394 in 499e4cd
|
@Haleygo, also updated the vmbackupmanager. LMK if you want to revert this change. |
6d7e769
to
91e88e8
Compare
Co-authored-by: Phuong Le <39565248+func25@users.noreply.github.com>
This is really needed 👍 Thanks for the quick update. |
20e16a2
to
2b11f66
Compare