Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[victoria-metrics-distributed] align vmauth-read with vmauth-write template #1511

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

olivierbouffet
Copy link
Contributor

@olivierbouffet olivierbouffet commented Sep 18, 2024

Hello,

Align the vmauth-read template with the vmauth-write template.

It fixes for me the issue #1510

after the patch I have the appropriate vmauth-global-read-vmdistributed-vm-distributed definition :

apiVersion: operator.victoriametrics.com/v1beta1
kind: VMAuth
metadata:
  annotations:
    meta.helm.sh/release-name: vmdistributed
    meta.helm.sh/release-namespace: vm
    operator.victoriametrics/last-applied-spec: '{"image":{"repository":"docker.io/victoriametrics/vmauth","tag":"v1.103.0","pullPolicy":"IfNotPresent"},"resources":{},"unauthorizedAccessConfig":[{"src_paths":["/select/.+"],"url_prefix":["http://vmauth-vmauth-read-proxy-aisle-a:8427/","http://vmauth-vmauth-read-proxy-aisle-b:8427/"],"load_balancing_policy":"first_available"}],"ip_filters":{}}'
  creationTimestamp: "2024-09-18T08:04:36Z"
  finalizers:
  - apps.victoriametrics.com/finalizer
  generation: 5
  labels:
    app.kubernetes.io/instance: vmdistributed
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: vm-distributed
    app.kubernetes.io/version: v1.103.0
    helm.sh/chart: victoria-metrics-distributed-0.3.0
  name: vmauth-global-read-vmdistributed-vm-distributed
  namespace: vm
  resourceVersion: "200899025"
  uid: 8e60ea28-b1e6-417e-80e4-d6c4d9d8d3d5
spec:
  image:
    pullPolicy: IfNotPresent
    repository: docker.io/victoriametrics/vmauth
    tag: v1.103.0
  unauthorizedAccessConfig:
  - load_balancing_policy: first_available
    src_paths:
    - /select/.+
    url_prefix:
    - http://vmauth-vmauth-read-proxy-aisle-a:8427/
    - http://vmauth-vmauth-read-proxy-aisle-b:8427/
status:
  updateStatus: operational

Hope this could help.

Olivier

Copy link
Contributor

@Haleygo Haleygo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Haleygo
Copy link
Contributor

Haleygo commented Sep 19, 2024

Thank you for contribution!

@Haleygo Haleygo merged commit 45a89c5 into VictoriaMetrics:master Sep 19, 2024
6 checks passed
AndrewChubatiuk pushed a commit that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants