fixed security issues

VictoriaMetrics · Jan 4, 2025 · 67c0d1e · 67c0d1e
1 parent 055185e
commit 67c0d1e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/hack/rules-and-dashboards/sync_dashboards.py b/hack/rules-and-dashboards/sync_dashboards.py
@@ -393,10 +393,9 @@ def write_dashboard_to_file(resource_name, content, charts):
 
 def jsonnet_import(directory, file_name):
     src = join(directory, file_name)
-    if file_name.startswith("github.com"):
-        (empty, repo_org, repo_name, repo_path) = urlparse(
-            f"https://{file_name}"
-        ).path.split("/", 3)
+    parsed_url = urlparse(f"https://{file_name}")
+    if parsed_url.hostname == "github.com":
+        (empty, repo_org, repo_name, repo_path) = parsed_url.path.split("/", 3)
         repo_slug = f"{repo_org}/{repo_name}"
         repo_resp = requests.get(f"https://api.github.com/repos/{repo_slug}")
         if repo_resp.status_code != 200:

diff --git a/hack/rules-and-dashboards/sync_rules.py b/hack/rules-and-dashboards/sync_rules.py
@@ -284,10 +284,9 @@ def write_group_to_file(group, url, charts):
 
 def jsonnet_import(directory, file_name):
     src = join(directory, file_name)
-    if file_name.startswith("github.com"):
-        (empty, repo_org, repo_name, repo_path) = urlparse(
-            f"https://{file_name}"
-        ).path.split("/", 3)
+    parsed_url = urlparse(f"https://{file_name}")
+    if parsed_url.hostname == "github.com":
+        (empty, repo_org, repo_name, repo_path) = parsed_url.path.split("/", 3)
         repo_slug = f"{repo_org}/{repo_name}"
         repo_resp = requests.get(f"https://api.github.com/repos/{repo_slug}")
         if repo_resp.status_code != 200: