Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-4042] Document CONNECT_WORKSPACE_URN option #72

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Conversation

amvertex
Copy link
Contributor

Summary

This PR updates the documentation to include information on how to set CONNECT_WORKSPACE_URN in order to automatically push data to a specific location in Connect.

@amvertex amvertex requested a review from a team as a code owner April 11, 2024 19:49
Comment on lines 100 to 109
:::tip
Scenes that are created or updated with the metadata key/value pair `"CONNECT_WORKSPACE_URN": "{YOUR_URN}"` will be added to the corresponding Connect workspace. This information can be added to the attributes section of your requests:
```
"attributes": {
"metadata": {
"CONNECT_WORKSPACE_URN": "{YOUR_URN}"
}
}
```
:::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of having a separate section for this on the Import Data page? Seems more related to the importing of your data vs rendering. Also guessing that the import data guide will expand with details about integrating with your PDM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair. How about this?

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@amvertex amvertex requested a review from danschultz April 12, 2024 20:56
Copy link
Contributor

@MadisonEhlers-Vertex MadisonEhlers-Vertex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amvertex amvertex enabled auto-merge (squash) April 15, 2024 18:09
Copy link
Contributor

@danschultz danschultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Offered an additional suggestion, otherwise LGTM.

@@ -254,3 +254,15 @@ curl --location --request GET \

</TabItem>
</Tabs>

:::tip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a tip, how about a new section Adding Scenes to Connect? This way it's listed in the TOC and allows for hyperlinking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to leave it as-is for now, because that might lead to a larger restructuring of how this information is grouped. I'm not sure it makes sense to have a full section called Adding Scenes to Connect, but not share how to create a scene until two pages later. I think it's a good idea for the future though!

@amvertex amvertex merged commit 2901904 into main Apr 16, 2024
2 checks passed
@amvertex amvertex deleted the workspace_urn branch April 16, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants