廃止: HTTP エラーと重複するエラーロギングを削除 (#1348)

* remove: HTTP エラーと重複する `print_exc()` を削除 * fix: lint
VOICEVOX · Jun 2, 2024 · f34da2f · f34da2f
1 parent d908da7
commit f34da2f
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 10 deletions.
diff --git a/voicevox_engine/app/routers/speaker.py b/voicevox_engine/app/routers/speaker.py
@@ -1,7 +1,6 @@
 """話者情報機能を提供する API Router"""
 
 import base64
-import traceback
 from pathlib import Path
 from typing import Annotated, Literal
 
@@ -126,7 +125,6 @@ def _speaker_info(
                     }
                 )
         except FileNotFoundError:
-            traceback.print_exc()
             msg = "追加情報が見つかりませんでした"
             raise HTTPException(status_code=500, detail=msg)
 

diff --git a/voicevox_engine/app/routers/user_dict.py b/voicevox_engine/app/routers/user_dict.py
@@ -1,6 +1,5 @@
 """ユーザー辞書機能を提供する API Router"""
 
-import traceback
 from typing import Annotated
 
 from fastapi import APIRouter, Body, Depends, HTTPException, Path, Query
@@ -35,7 +34,6 @@ def get_user_dict_words() -> dict[str, UserDictWord]:
         except UserDictInputError as err:
             raise HTTPException(status_code=422, detail=str(err))
         except Exception:
-            traceback.print_exc()
             raise HTTPException(
                 status_code=500, detail="辞書の読み込みに失敗しました。"
             )
@@ -81,7 +79,6 @@ def add_user_dict_word(
         except UserDictInputError as err:
             raise HTTPException(status_code=422, detail=str(err))
         except Exception:
-            traceback.print_exc()
             raise HTTPException(
                 status_code=500, detail="ユーザー辞書への追加に失敗しました。"
             )
@@ -132,7 +129,6 @@ def rewrite_user_dict_word(
         except UserDictInputError as err:
             raise HTTPException(status_code=422, detail=str(err))
         except Exception:
-            traceback.print_exc()
             raise HTTPException(
                 status_code=500, detail="ユーザー辞書の更新に失敗しました。"
             )
@@ -153,7 +149,6 @@ def delete_user_dict_word(
         except UserDictInputError as err:
             raise HTTPException(status_code=422, detail=str(err))
         except Exception:
-            traceback.print_exc()
             raise HTTPException(
                 status_code=500, detail="ユーザー辞書の更新に失敗しました。"
             )
@@ -180,7 +175,6 @@ def import_user_dict_words(
         except UserDictInputError as err:
             raise HTTPException(status_code=422, detail=str(err))
         except Exception:
-            traceback.print_exc()
             raise HTTPException(
                 status_code=500, detail="ユーザー辞書のインポートに失敗しました。"
             )

diff --git a/voicevox_engine/user_dict/user_dict_manager.py b/voicevox_engine/user_dict/user_dict_manager.py
@@ -3,7 +3,6 @@
 import json
 import sys
 import threading
-import traceback
 from collections.abc import Callable
 from pathlib import Path
 from typing import Any, Final, TypeVar
@@ -160,7 +159,6 @@ def _update_dict(
 
     except Exception as e:
         print("Error: Failed to update dictionary.", file=sys.stderr)
-        traceback.print_exc(file=sys.stderr)
         raise e
 
     finally: