fix(TabsItem): use hasReactNode for status (#6125)

* fix(TabsItem): use hasReactNode for status * test(TabsItem): extend e2e config with status={0}
VKCOM · Nov 20, 2023 · 3ecc3d9 · 3ecc3d9
1 parent aea2148
commit 3ecc3d9
Show file tree

Hide file tree

Showing 12 changed files with 23 additions and 23 deletions.
diff --git a/packages/vkui/src/components/Tabs/Tabs.e2e-playground.tsx b/packages/vkui/src/components/Tabs/Tabs.e2e-playground.tsx
@@ -111,7 +111,7 @@ export const TabsPlayground = (props: ComponentPlaygroundProps) => {
             >
               <TabsItem>Лента</TabsItem>
             </Unscrollable>,
-            <Unscrollable key="tabs" status={23} />,
+            <Unscrollable key="tabs" status={0} />,
             <Unscrollable key="tabs" status={23}>
               <TabsItem>Лента</TabsItem>
             </Unscrollable>,

diff --git a/...i/src/components/Tabs/__image_snapshots__/tabs-android-chromium-dark-1-snap.png b/...i/src/components/Tabs/__image_snapshots__/tabs-android-chromium-dark-1-snap.png
diff --git a/.../src/components/Tabs/__image_snapshots__/tabs-android-chromium-light-1-snap.png b/.../src/components/Tabs/__image_snapshots__/tabs-android-chromium-light-1-snap.png
diff --git a/...es/vkui/src/components/Tabs/__image_snapshots__/tabs-ios-webkit-dark-1-snap.png b/...es/vkui/src/components/Tabs/__image_snapshots__/tabs-ios-webkit-dark-1-snap.png
diff --git a/...s/vkui/src/components/Tabs/__image_snapshots__/tabs-ios-webkit-light-1-snap.png b/...s/vkui/src/components/Tabs/__image_snapshots__/tabs-ios-webkit-light-1-snap.png
diff --git a/...kui/src/components/Tabs/__image_snapshots__/tabs-vkcom-chromium-dark-1-snap.png b/...kui/src/components/Tabs/__image_snapshots__/tabs-vkcom-chromium-dark-1-snap.png
diff --git a/...ui/src/components/Tabs/__image_snapshots__/tabs-vkcom-chromium-light-1-snap.png b/...ui/src/components/Tabs/__image_snapshots__/tabs-vkcom-chromium-light-1-snap.png
diff --git a/...vkui/src/components/Tabs/__image_snapshots__/tabs-vkcom-firefox-dark-1-snap.png b/...vkui/src/components/Tabs/__image_snapshots__/tabs-vkcom-firefox-dark-1-snap.png
diff --git a/...kui/src/components/Tabs/__image_snapshots__/tabs-vkcom-firefox-light-1-snap.png b/...kui/src/components/Tabs/__image_snapshots__/tabs-vkcom-firefox-light-1-snap.png
diff --git a/.../vkui/src/components/Tabs/__image_snapshots__/tabs-vkcom-webkit-dark-1-snap.png b/.../vkui/src/components/Tabs/__image_snapshots__/tabs-vkcom-webkit-dark-1-snap.png
diff --git a/...vkui/src/components/Tabs/__image_snapshots__/tabs-vkcom-webkit-light-1-snap.png b/...vkui/src/components/Tabs/__image_snapshots__/tabs-vkcom-webkit-light-1-snap.png
diff --git a/packages/vkui/src/components/TabsItem/TabsItem.tsx b/packages/vkui/src/components/TabsItem/TabsItem.tsx
@@ -1,5 +1,5 @@
 import * as React from 'react';
-import { classNames } from '@vkontakte/vkjs';
+import { classNames, hasReactNode } from '@vkontakte/vkjs';
 import { useAdaptivity } from '../../hooks/useAdaptivity';
 import { useExternRef } from '../../hooks/useExternRef';
 import { usePrevious } from '../../hooks/usePrevious';
@@ -75,7 +75,7 @@ export const TabsItem = ({
 
   const isTabFlow = role === 'tab';
 
-  if (status) {
+  if (hasReactNode(status)) {
     statusComponent =
       typeof status === 'number' ? (
         <Subhead