Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare category additions as readonly properties, instead of instance methods, for better Swift compatibility #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JRG-Developer
Copy link

This PR changes category additions to readonly properties, instead of instance methods.

This way, they are correctly converted to Swift computed properties automatically.

Otherwise, as with the current version, you'd need to declare obfuscated strings like this:

NSMutableString().p().a().s().s().w().o().r().d

With this PR accepted, you'll be able to declare obfuscated strings as intended like this:

NSMutableString().p.a.s.s.w.o.r.d

…e methods.

This way, they are correctly converted to Swift computed properties automatically.
@JRG-Developer JRG-Developer changed the title Declare category additions as readonly properties, instead of instance methods Declare category additions as readonly properties, instead of instance methods, for better Swift compatibility Jul 21, 2016
@coneybeare
Copy link
Member

We used to have it like this, but I can't remember why we changed it, maybe subclassing reasons? Seeing as swift is the future, I am inclined to accept the PR, but it's been awhile since I've done any obj-c dev and want to hear from others about the potential pitfalls from removing instancetype

Copy link

@RomanPodymov RomanPodymov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @JRG-Developer
There are no UAObfuscatedString.h and UAObfuscatedString.m in the project. Please close this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants