L1 notifier #23
Open
L1 notifier #23
+765
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review, open items here are measuring the gas usage on L2 and adjusting the gas costs for the deposit transactions on L1, I would suggest merging this PR and revisiting the gas costs later once we have those contracts built |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
StakingMiddlewaredocumentation and the addition of new components to the system. The most significant changes are the introduction of theNotifiercontract and updates to existing contracts to integrate withNotifier.Documentation Updates:
docs/autogen/src/SUMMARY.md: Added entries forNotifierandINotifierto the documentation summary. [1] [2]New Components:
docs/autogen/src/src/UVN/L1/StakingMiddleware/Notifier.sol/abstract.Notifier.md: Added documentation for the newNotifiercontract, which allows operators to mint ERC721 tokens and notify service contracts of stake changes.docs/autogen/src/src/interfaces/UVN/L1/StakingMiddleware/INotifier.sol/interface.INotifier.md: Added documentation for theINotifierinterface, detailing functions and events related to theNotifiercontract.Integration with Notifier:
docs/autogen/src/src/UVN/L1/StakingMiddleware.sol/contract.StakingMiddleware.md: Updated to includeNotifierin the inheritance and constructor. [1] [2]docs/autogen/src/src/UVN/L1/StakingMiddleware/README.md: AddedNotifierto the contents.Refactoring and Renaming:
docs/autogen/src/src/UVN/L1/StakingMiddleware/DelegatorAccessControl.sol/abstract.DelegatorAccessControl.md: RenamedAccessControlstruct toAccessControlParams. [1] [2]docs/autogen/src/src/UVN/L1/StakingMiddleware/StakeManager.sol/contract.StakeManager.md: Renamed_beforeSlashand_afterSlashfunctions to_beforeDelegatorSlashedand_afterDelegatorSlashed.docs/autogen/src/src/UVN/L1/StakingMiddleware/UniStakerWrapper.sol/contract.UniStakerWrapper.md: Updated function names to match the new naming convention for slashing-related functions.