-
Notifications
You must be signed in to change notification settings - Fork 4
Add support for a menu of SSO login options #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some (minor) comments below
63581ed
to
d928fe9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to test it, but now I can't the server off the ground again. Complains about the usage of a non-existant SITE_DIR
variable in my localsettings.py
(which comes from the README suggestion)
Argus readme or argus-htmx readme? |
argus-htmx, IIRC :) |
I guess you are already in the process of updating the README in #204 . I tried removing the
Just trying to add stuff to |
coincidentally, I've added a PR to update the docs concerning federated logins to clarify some things, especially wrt AUTHENTICATION_BACKENDS and the social urls Uninett/Argus#926 |
Thanks a bunch, @elfjes, that tiny bit of doc was all I needed to correctly configure my url patterns (I've done so little Argus coding this past year that I no longer know where to look 😆 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With help from @elfjes I am now able to test this, and it looks and works fine. But there's still a tiny docs typo :)
See https://indieweb.org/NASCAR_problem
In order to properly test this you need one or more python social auth provider backends added to
AUTHENTICATION_BACKENDS
and the necessary KEY and SECRET set up in settings.See argus-server docs for more info.