Skip to content
This repository has been archived by the owner on Feb 11, 2025. It is now read-only.

Add support for a menu of SSO login options #166

Merged
merged 8 commits into from
Oct 28, 2024
Merged

Add support for a menu of SSO login options #166

merged 8 commits into from
Oct 28, 2024

Conversation

hmpf
Copy link
Collaborator

@hmpf hmpf commented Oct 10, 2024

See https://indieweb.org/NASCAR_problem

In order to properly test this you need one or more python social auth provider backends added to AUTHENTICATION_BACKENDS and the necessary KEY and SECRET set up in settings.

See argus-server docs for more info.

@hmpf hmpf self-assigned this Oct 10, 2024
@hmpf hmpf requested review from a team October 10, 2024 12:59
@hmpf hmpf added the enhancement New feature or request label Oct 10, 2024
Copy link
Contributor

@elfjes elfjes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some (minor) comments below

@hmpf hmpf requested a review from elfjes October 17, 2024 12:44
@hmpf hmpf force-pushed the oauth2 branch 4 times, most recently from 63581ed to d928fe9 Compare October 24, 2024 13:34
@hmpf hmpf requested a review from saket-geant October 28, 2024 11:49
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to test it, but now I can't the server off the ground again. Complains about the usage of a non-existant SITE_DIR variable in my localsettings.py (which comes from the README suggestion)

@hmpf
Copy link
Collaborator Author

hmpf commented Oct 28, 2024

Trying to test it, but now I can't the server off the ground again. Complains about the usage of a non-existant SITE_DIR variable in my localsettings.py (which comes from the README suggestion)

Argus readme or argus-htmx readme?

@lunkwill42
Copy link
Member

Argus readme or argus-htmx readme?

argus-htmx, IIRC :)

@hmpf hmpf requested a review from lunkwill42 October 28, 2024 12:35
@lunkwill42
Copy link
Member

Argus readme or argus-htmx readme?

argus-htmx, IIRC :)

I guess you are already in the process of updating the README in #204 . I tried removing the TEMPLATES setting that was suggested in previous documentation, and I got a bit further, but am now getting this instead, when visiting /incidents/:

django.urls.exceptions.NoReverseMatch: 'social' is not a registered namespace

Just trying to add stuff to AUTHENTICATION_BACKENDS as suggested by the argus-server docs does not help. I assume there is even more url-config that must be added in order to work with PSA...

@elfjes
Copy link
Contributor

elfjes commented Oct 28, 2024

Argus readme or argus-htmx readme?

argus-htmx, IIRC :)

I guess you are already in the process of updating the README in #204 . I tried removing the TEMPLATES setting that was suggested in previous documentation, and I got a bit further, but am now getting this instead, when visiting /incidents/:

django.urls.exceptions.NoReverseMatch: 'social' is not a registered namespace

Just trying to add stuff to AUTHENTICATION_BACKENDS as suggested by the argus-server docs does not help. I assume there is even more url-config that must be added in order to work with PSA...

coincidentally, I've added a PR to update the docs concerning federated logins to clarify some things, especially wrt AUTHENTICATION_BACKENDS and the social urls Uninett/Argus#926

@lunkwill42
Copy link
Member

coincidentally, I've added a PR to update the docs concerning federated logins to clarify some things, especially wrt AUTHENTICATION_BACKENDS and the social urls Uninett/Argus#926

Thanks a bunch, @elfjes, that tiny bit of doc was all I needed to correctly configure my url patterns (I've done so little Argus coding this past year that I no longer know where to look 😆 )

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With help from @elfjes I am now able to test this, and it looks and works fine. But there's still a tiny docs typo :)

@hmpf hmpf requested a review from lunkwill42 October 28, 2024 13:13
@hmpf hmpf merged commit e6b1ad5 into Uninett:main Oct 28, 2024
3 of 4 checks passed
@hmpf hmpf deleted the oauth2 branch October 28, 2024 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants