Check for duplicate levels in isentropic_interpolation_as_dataset #3323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Unidata#3309 by provided the user with a warning when interpolation to a duplicate isentropic surface is requested. This is likely a mistake on the part of the user, but by issuing a warning rather than an error, computations can proceed if the duplication was really intended. The code used here is an adaptation of the duplicate-level check found in _parcel_profile_helper elsewhere in thermo.py.
|
Please let me know if you'd like me to try to appease the bot. |
|
@sgdecker We discussed #3309 on our MetPy dev call this morning and arrived at the solution to issue a warning...and then saw your PR. 😆 Thanks for submitting it! Looks good. I went ahead and pushed a commit that did the refactor to appease the bot. @dcamron This will need your review since I committed here. |
Move common test data to a fixture to reduce noise in tests.
dopplershift
force-pushed
the
fix3309
branch
from
ef7db9a to
34ac58e
Compare
dopplershift
added
Type: Enhancement
dcamron
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
A duplicate-level check is added, using the same approach as in
_parcel_profile_helper.Checklist