Refactor moist_lapse #2263
Merged
Refactor moist_lapse #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ports to use the better-supported solve_ivp interface from scipy. This allows us to simplify the logic around using a reference temperature as a starting point, and gets away from warnings/errors when desired values are too close to this starting point.
dopplershift
added
Type: Enhancement
3 tasks
dopplershift
added a commit
that referenced
this pull request
Jul 21, 2023
This test was added in #2263, but not sure if the functionality worked before then. Regardless, scipy now disallows passing nan for initial values to solve_ivp, so instead of trying to hack around it, just let the scipy error persist and don't trigger it in our code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This ports to use the better-supported
solve_ivpinterface from scipy. This allows us to simplify the logic around using a reference temperature as a starting point, and gets away from warnings/errors when desired values are too close to this starting point. This required tweaking a couple of tests (image tests are hyper sensitive and there was one test that didn't set required digits like the rest.)Checklist