Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add smoothing for declarative #2156

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Conversation

kgoebber
Copy link
Collaborator

Description Of Changes

This PR completes another portion of issue #1016 with improvements to the declarative plotting interface by adding an attribute to perform a 9-pt smoother on the selected field. The implementation allows for inputing an integer to set the number of passes for smoothing and defaults to None for no smoothing.

To align with the PR #2155 this attribute is named field_smooth, but is open to other naming conventions based on the collective wisdom of the group.

Checklist

@kgoebber kgoebber requested a review from a team as a code owner October 15, 2021 02:57
@kgoebber kgoebber requested review from dcamron and removed request for a team October 15, 2021 02:57
@dopplershift dopplershift added Area: Plots Pertains to producing plots Type: Enhancement Enhancement to existing functionality labels Oct 15, 2021
@dopplershift dopplershift added this to the 1.2.0 milestone Oct 15, 2021
@kgoebber kgoebber force-pushed the add_declarative_smooth branch 3 times, most recently from 09665ba to 6fedf97 Compare November 8, 2021 22:43
Copy link
Member

@dcamron dcamron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly ready to go. Thanks for adding these!

@kgoebber kgoebber force-pushed the add_declarative_smooth branch from 6fedf97 to edae5ad Compare November 10, 2021 21:25
@dcamron dcamron merged commit cdecf1c into Unidata:main Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Plots Pertains to producing plots Type: Enhancement Enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Declarative Plotting Interface Improvements
3 participants