Convert instances of boolean indexing to ndarrays to pass dask tests in basic module #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpmanser
force-pushed
the
fix_dask_in_basic
branch
from
9931b53 to
e8da3b9
Compare
rpmanser
commented
Sep 14, 2021
|
Rebasing this on main should get it passing. |
rpmanser
force-pushed
the
fix_dask_in_basic
branch
from
e8da3b9 to
4c9c948
Compare
rpmanser
changed the title
|
This should be good to go unless anyone has additional comments or changes. In the last force push I sneaked in the use of |
dopplershift
approved these changes
Sep 24, 2021
dopplershift
added
Area: Calc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This PR fixes bugs discovered in #1935 related to passing dask arrays as arguments to
wind_direction,heat_index, andapparent_temperature.daskneeds to know the resulting dimensions of the indexed array when performing item assignment, so boolean indexes are converted to ndarray to solve this.With this PR, it seems safe to say that the basic module now supports dask arrays. Should this be included in the documentation, or do we want to wait until most of the calc module has support for dask arrays?
Checklist