Streaming support in Udash REST #1338
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since @mrzysztof is taking over this, I think @sebaciv could review. I'll take a look but won't have the time to be the primary reviewer here. |
sebaciv
commented
Apr 9, 2025
rest/jetty/src/main/scala/io/udash/rest/jetty/JettyRestClient.scala
Outdated
Show resolved
Hide resolved
| @@ -129,6 +146,52 @@ trait RestApiTestScenarios extends RestApiTest { | |||
| } | |||
| } | |||
|
|
|||
| class DirectRestApiTest extends RestApiTestScenarios { | |||
| def clientHandle: HandleRequest = serverHandle | |||
| // TODO streaming MORE tests: cancellation, timeouts, errors, errors after sending a few elements, custom format, slow source observable | |||
There was a problem hiding this comment.
I can't find tests for mid-stream Observable cancellation (both server and client side), is this corner case unhandled?
There was a problem hiding this comment.
I tinkered with that, but in the end, I am not really sure what the expected outcome is here.
Suppose we cancel the subscription from the client. What do we want to test here?
sebaciv
commented
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable returning monix.Observable in REST RPC traits and stream response when sending it over the wire.
State of this pull request (missing items):