Deploy to stage #639
Merged
Deploy to stage #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late Remove debugging print statement in template
This is the version of ACM that has custom workspace adapter methods implemented, and I'd like to test it out before releasing the new version of the package. CI will fail because the version in the requirements.in file does not have the version in requirements.txt. This is good, because we need to update requirements.in with the official released version once it's ready.
This will be used in the adapters where we are going to create our own auth domains.
These will be filled in in future commits.
Create an auth domain based on the name of the workspace. Add the admins group as an admin of the auth domain. Share the workspace with the auth domain as an owner.
Instead of just testing everything through the view, add specific tests for the adapter methods.
The adapter method names chnaged from eg before_workspace_create to before_anvil_create. Update the CDSA code to use those names.
We'll want to use the methods that create the uath domain and that share a workspace with the admins elsewhere, so move the code into a set of resuable classes that can be inherited in the workspae adapters.
Add the two new adapter mixins to the dbGaPWorkspaceAdapter. This means that a dbGaPWorkspace will get an auth domain automatically created, the admins group will be added to it, and the workspace will be shared with the admins group as an owner.
Automatically create an auth domain, add the admins group to the auth domain, and share the workspace with the admins group.
This disables the auth domain field, which is a better user experience when the auth domain will be automatically created.
Add the WorkspaceAdminSharingAdapter mixin to all other workspace adapters, which will automatically share th workspace with the admins group as an owner after it's created.
Instead of essentially repeating the same tests fora ll the adapters, just test the adapter mixins themselves directly once. The actual workspace adapters themselves are still tested via the create views.
requirements.txt will be updated by CI.
…es/637 Update requirements file for feature/acm-v0.24-and-custom-adapter-methods
…ter-methods ACM v0.24 and custom adapter methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.