Skip to content

Commit

Permalink
chore: Update node to LTS (#1229)
Browse files Browse the repository at this point in the history
Update node to LTS
  • Loading branch information
spardue authored Mar 27, 2024
1 parent 6cb3a1c commit 3fdc2d1
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.19.0
20.11.1
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nodejs 18.19.0
nodejs 20.11.1
10 changes: 5 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ ARG OPENSSL_TAG=18.18
##--------- Stage: builder ---------##
# Node image variant name explanations: "slim" only contains the minimal packages needed to run Node
#FROM ${BASE_REGISTRY}/${BASE_IMAGE}:${BASE_TAG} AS builder
FROM registry1.dso.mil/ironbank/opensource/nodejs/nodejs18:18.18.2-slim AS builder
FROM registry1.dso.mil/ironbank/opensource/nodejs/nodejs20:20.11 AS builder

WORKDIR /app

Expand Down Expand Up @@ -41,7 +41,7 @@ COPY . .

# E2E image for running tests (same as prod but without certs)
#FROM ${BASE_REGISTRY}/${BASE_IMAGE}:${BASE_TAG} AS e2e
FROM registry1.dso.mil/ironbank/opensource/nodejs/nodejs18:18.18.2-slim AS e2e
FROM registry1.dso.mil/ironbank/opensource/nodejs/nodejs20:20.11 AS e2e

WORKDIR /app

Expand All @@ -68,12 +68,12 @@ CMD ["-r","./startup/index.js", "node_modules/.bin/next", "start"]
##--------- Stage: build-openssl ---------##
# This image has OpenSSL 3 builtin so we can copy it from here
#FROM ${BASE_REGISTRY}/${BASE_IMAGE}:${OPENSSL_TAG} AS build-openssl
FROM registry1.dso.mil/ironbank/opensource/nodejs/nodejs18:18.18.2-slim AS build-openssl
FROM registry1.dso.mil/ironbank/opensource/nodejs/nodejs20:20.11 AS build-openssl

##--------- Stage: build-env ---------##
# Pre-Production image, run scripts and copy outputs to final image
#FROM ${BASE_REGISTRY}/${BASE_IMAGE}:${BASE_TAG} AS build-env
FROM registry1.dso.mil/ironbank/opensource/nodejs/nodejs18:18.18.2-slim AS build-env
FROM registry1.dso.mil/ironbank/opensource/nodejs/nodejs20:20.11 AS build-env

WORKDIR /app

Expand All @@ -89,7 +89,7 @@ RUN cat /usr/local/share/ca-certificates/DoD_Root_CA_3.crt > /usr/local/share/ca

##--------- Stage: runner ---------##
# Final Production image
FROM registry1.dso.mil/ironbank/opensource/nodejs/nodejs18:18.18.2-slim AS runner
FROM registry1.dso.mil/ironbank/opensource/nodejs/nodejs20:20.11 AS runner

WORKDIR /app

Expand Down
4 changes: 2 additions & 2 deletions Dockerfile-gh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
##--------- Stage: builder ---------##
# Node image variant name explanations: "bookworm" is the codeword for Debian 12, and "slim" only contains the minimal packages needed to run Node
FROM node:18.19.0-bookworm-slim AS builder
FROM node:20.11.1-bookworm-slim AS builder

RUN apt-get update \
&& apt-get dist-upgrade -y \
Expand Down Expand Up @@ -65,7 +65,7 @@ CMD ["-r","./startup/index.js", "node_modules/.bin/next", "start"]
##--------- Stage: build-env ---------##

# Production image, copy all the files and run next
FROM node:18.19.0-bookworm-slim AS build-env
FROM node:20.11.1-bookworm-slim AS build-env

WORKDIR /app

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "4.31.2",
"private": true,
"engines": {
"node": "^18.14.2"
"node": "^20.11.1"
},
"repository": {
"type": "git",
Expand Down

0 comments on commit 3fdc2d1

Please sign in to comment.