Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo ist still on version 1 of https://github.com/UKHomeOffice/sas-github-workflows. In V2 the versioning and tagging is done on merge of PR to main. By default these use
ci --ignore-scripts
. Because the repo used deprecatedprepublish
which only runs beforenpm ci
andnpm install
the--ignore-scripts
was causing the npm artefact to be published without the built js files.I've updated the repo to use
prepare
which runs on install and publish.There are some other issues with this workflow that I'm hoping to fix:
This copies the npm publish workflow from
sas-github-workflows
, with modifications to correct the above issues.contents: read
->contents: write
Once tested here, the changes will be submitted to
sas-github-workflows
and if accepted the custom workflow will be replaced with the shared v2 workflow.Dependency updates
The module was failing to pass audit tests due to a large number of critical vulnerabilities. To fix this:
There a number of further changes to plugins and config for the above.