Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOFF-1121 : Update html-pdf-converter image with latest v3.0.0 #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HOFF-1121 : Update html-pdf-converter image with latest v3.0.0 #45

wants to merge 1 commit into from

Conversation

adityababumallisettiHO
Copy link
Collaborator

What?

  • Using html-pdf-converter image with Node v 22 and upgraded node packages
  • Fixed vulnerabilities in the image
  • Testing in Branch env

Why?

  • Large number of Critical and High CVE Vulnerabilities have been detected by Trivy Scan
  • Node image v18 is outdated. HOF is moving to v20 and v22 in future Road Map.

How?

  • Replace html-pdf-converter image with latest
  • Add a comment to explain the version and Date.

Testing?

  • Smoke tests done on firearms, received notification
  • Regression testing in Branch and then merge to master to deploy and test in UAT, Stage and promote to Prod
  • Check boxes will ticked as we pass through each env
  • Branch
  • UAT
  • Prod

Screenshots (optional)

Anything Else? (optional)

  • Drone build is successful
  • Pods are Healthy
  • Staging environment has been commented out in pipeline 4 years ago by team

Check list

  • I have reviewed my own pull request for linting issues (e.g. adding new lines)
  • I have written tests (if relevant)
  • I have created a JIRA number for my branch
  • I have created a JIRA number for my commit
  • I have followed the chris beams method for my commit https://cbea.ms/git-commit/
    here is an example commit
  • Ensure drone builds are green especially tests
  • I will squash the commits before merging

@adityababumallisettiHO
Update html-pdf-deployment.yml
9cdd30c 
HOFF-1121: Update html-pdf-converter image to latest v3.0.0

* Using Node v 22 and upgraded node packages
* Fixed vulnerabilities in the image
* Digest Ensures immutability and security by locking the exact image content.
* Combining both provides clarity while ensuring traceability and reliability in deployments.
Jholderdevops
Jholderdevops approved these changes Feb 27, 2025
View reviewed changes
Copy link

@Jholderdevops Jholderdevops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jholderdevops Jholderdevops Jholderdevops approved these changes

Assignees

@adityababumallisettiHO adityababumallisettiHO

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adityababumallisettiHO @Jholderdevops