Skip to content

Commit

Permalink
Merge pull request #19 from Tradeshift/node16
Browse files Browse the repository at this point in the history
  • Loading branch information
Jacob Wejendorp authored Jan 21, 2022
2 parents 4adbcad + afda491 commit 5052c73
Show file tree
Hide file tree
Showing 8 changed files with 35 additions and 35 deletions.
13 changes: 2 additions & 11 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@v2
with:
node-version: 14
node-version: 16
registry-url: 'https://npm.pkg.github.com'
cache: 'npm'

Expand All @@ -37,7 +37,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@v2
with:
node-version: 14
node-version: 16
registry-url: 'https://npm.pkg.github.com'
cache: 'npm'

Expand All @@ -51,15 +51,6 @@ jobs:
uses: ./ # Uses an action in the root directory
id: semantic-release
with:
branches: |
[
'+([0-9])?(.{+([0-9]),x}).x',
'master',
'next',
'next-major',
{name: 'beta', prerelease: true},
{name: 'alpha', prerelease: true}
]
registry: https://npm.pkg.github.com/
npm_publish: true
env:
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
12
16
18 changes: 0 additions & 18 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,6 @@ steps:
uses: tradeshift/actions-semantic-release@v1
id: semantic-release
with:
branches: |
[
'+([0-9])?(.{+([0-9]),x}).x',
'master',
'next',
'next-major',
{name: 'beta', prerelease: true},
{name: 'alpha', prerelease: true}
]
registry: https://npm.pkg.github.com/
npm_publish: true
env:
Expand All @@ -46,15 +37,6 @@ steps:
- name: 🚀 Dry run release
uses: tradeshift/actions-semantic-release@v1
with:
branches: |
[
'+([0-9])?(.{+([0-9]),x}).x',
'master',
'next',
'next-major',
{name: 'beta', prerelease: true},
{name: 'alpha', prerelease: true}
]
registry: https://npm.pkg.github.com/
# Dry run and publish the changelog as a Check
dry_run: true
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,5 @@ outputs:
new_release_notes:
description: 'The release notes for the new release.'
runs:
using: 'node12'
using: 'node16'
main: 'index.js'
12 changes: 12 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
"description": "",
"main": "index.js",
"scripts": {
"test": "echo derp",
"validate": "echo valid!"
"validate": "tsc"
},
"repository": {
"type": "git",
Expand All @@ -22,5 +21,9 @@
"@actions/exec": "^1.0.4",
"@actions/github": "^5.0.0",
"semantic-release": "^17.3.0"
},
"devDependencies": {
"@types/node": "^17.0.10",
"typescript": "^4.5.5"
}
}
7 changes: 5 additions & 2 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ const updateStatus = async (/** @type {Result} */ result) => {
].join('\n\n');
}

await octokit.checks.create({
await octokit.rest.checks.create({
owner: gitHubRepoOwner,
repo: gitHubRepoName,
name: checkName,
Expand Down Expand Up @@ -156,5 +156,8 @@ const collectOutput = async (result) => {

module.exports = () => {
core.debug('Initialization successful');
release().catch(core.setFailed);
release().catch((err) => {
console.error(err);
core.setFailed('Failed to run semantic-release');
});
};
9 changes: 9 additions & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"compilerOptions": {
"noEmit": true,
"allowJs": true,
"checkJs": true,
"resolveJsonModule": true
},
"include": ["src/**/*"]
}

0 comments on commit 5052c73

Please sign in to comment.