-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Venue blackout dates #51
Comments
I'm guessing blackout dates define a period during which the venue is not available because of some outside activity, like facility maintenance or other scheduled events (versus events scheduled through openassign). Do I understand this correctly? I gather we're really talking about blackout periods, each defined as a pair of dates, correct? Can we assign n blackout periods to a venue? Does each require explanation or description? What roles / permissions are required to assign, change, and remove blackout dates? |
Correct on all counts. A description is a good idea. For now, let's just give permission to Admin. |
A few detail questions regarding blackout periods: I'm currently planning to use methods on the VenueManager to add / edit / remove blackout periods for a given venue. In the interest of uniformity, should I instead create a BlackoutPeriodManager for the new model, with standard create/update methods? I assume the start and end dates for a blackout period are whole days, and not time values (ie, "ending at 2pm EST on Oct 20"). I'm looking for ways to enforce this "coarseness" on the field or its widgets. Suggestions are welcome if there's a standard idiom in Django or PR. I assume blackout periods will affect calls to these methods: I assume we won't offer blacked-out venues when scheduling new sessions. But should we block the creation or assignment of a session in this situation? If so, is there an existing exception class that would be most appropriate here? Similarly, should we block the modification of start / end dates for an existing blackout period, if this would conflict with already-scheduled sessions in this venue? If so, I assume we throw the same exception type as above. |
I think there should be a BlackoutPeriodManager. I'm not sure about the whole days issue. I've queried Ryan, and we'll We do not need to worry about resources with this. Let's not block assignment creation if a session ends up scheduled Let's not prevent modification or creation of a blackout period even On Mon, Jan 16, 2012 at 12:03 AM, Jim Allman
|
It would be beneficial to specify a blackout period with greater granularity than just days. For example, Jan 16 11:30AM to Jan 16 5:15PM. Such a blackout might be due to any number of facility needs which do not need to be known to the system in any greater detail. (we could just use the reservation system, but then we would have other problems like mixing in facilities 'events' with the kinds of events we actually care about) A blackout of a partial day may have the effect of preventing a training event from being assigned on the same day - but it may not. That depends on the event requirements and should not be dictated by a system which fails to represent an accurate picture of blackout reality. I suggest handling this in a manner similar to how we set up reservations for learning events. Of course, this would also allow a blackout period be used to make entire days or weeks unavailable as you were probably imagining. Agreed - resources can be handled at a later date. Michael's comments are spot on. A blackout period should mask the venue such that no NEW events can be scheduled on top of the blackout period. If something is already there the admin will need to deal with it - not the blackout period manager . When assigning a blackout period, it would be appropriate to see what is already scheduled and alert the admin, but not prevent assignment of the blackout. |
Allow one or more BlackoutPeriods for any Venue (re #51)
I'm grabbing this issue for a bit to add a couple of minor features that the UI needs. |
…abase table for the new BlackoutPeriod model.
…red(), which is more useful to the UI than just a list of IDs.
We need the ability to assign blackout dates to a venue. This should probably be a simple model with a venue FK, start datetime and end datetime.
Some care will need to be made to incorporate consideration of these blackout dates into the existing logic that determines if a venue is available, or what venues are available during a specified period.
The text was updated successfully, but these errors were encountered: