Allow one or more BlackoutPeriods for any Venue (re #51) #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
re #51: These changes were in response to the "Venue blackout dates" ticket. |
mhrivnak
added a commit
that referenced
this pull request
Jan 18, 2012
Allow one or more BlackoutPeriods for any Venue (re #51)
| """ | ||
| blame = PRForeignKey(Blame, null=True) | ||
| venue = PRForeignKey(Venue, related_name='blackout_periods') | ||
| start = models.DateField() |
There was a problem hiding this comment.
These will both need to be changed to DateTimeField so they can store time of day. Interestingly, a unit test is failing as a result, but I think it will only fail during certain times of the day! I believe it will fail any time 2 hours and 12 hours into the future are both on the same day.
======================================================================
FAIL: test_get_available_venues (pr_svc_tests.tests_svc.TestVenueManagerSvc)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/mhrivnak/git/openassign-server/pr_svc_tests/tests_svc.py", line 1032, in test_get_available_venues
self.assertEquals(len(ret['value']), 1)
AssertionError: 2 != 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested, a blackout period can begin or end at any time of the day.