Small refactor of unit tests to consolidate language and add a query and check helper to test_ingestion.py
#176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
query_vectors
toqueries
to match whatingest()
calls ittest_ingestion.py
which queries and checks for equalityTesting
Note
Let me know if you would like us to name everything
query_vectors
instead ofqueries
, I don't mind either way, but seems nice to pick one for public facing code.TODO
Would be also nice to consolidate language (i.e.
query_vectors
vsqueries
) in the.ipynb
's - will ask offline about how to propagate those changes to cloud, and also will do those updates in a separate PR.