Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactor of unit tests to consolidate language and add a query and check helper to test_ingestion.py #176

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

jparismorgan
Copy link
Contributor

What

  • Changes naming from query_vectors to queries to match what ingest() calls it
  • Adds a helper to test_ingestion.py which queries and checks for equality

Testing

  • Unit tests pass

Note

Let me know if you would like us to name everything query_vectors instead of queries, I don't mind either way, but seems nice to pick one for public facing code.

TODO

Would be also nice to consolidate language (i.e. query_vectors vs queries) in the .ipynb's - will ask offline about how to propagate those changes to cloud, and also will do those updates in a separate PR.

@jparismorgan jparismorgan marked this pull request as ready for review December 20, 2023 17:11
@jparismorgan jparismorgan merged commit 9c029e9 into main Dec 21, 2023
4 checks passed
@jparismorgan jparismorgan deleted the jparismorgan/unit-test-improvements branch December 21, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants