Skip to content
This repository has been archived by the owner on Nov 2, 2019. It is now read-only.

Add Validation #31

Merged
merged 4 commits into from
Apr 6, 2016
Merged

Add Validation #31

merged 4 commits into from
Apr 6, 2016

Conversation

brentdur
Copy link
Contributor

@brentdur brentdur commented Apr 3, 2016

Should take care of #28

Checks that N number starts with N and is followed by 8 numbers
Checks that email matches browser default
Checks that name is at least two words, starting with capital letter, separated by whitespace

@ycp217 please make sure this matches what you have in mind!

@AbhiAgarwal
Copy link
Member

@brentdur The validation stuff looks good! I understand your reasoning behind not letting people edit as then we have to re-search using the API / the logic there is a little messy. I think there should be some way to do it, though. How do you think we can do it besides a reset button?

@brentdur
Copy link
Contributor Author

brentdur commented Apr 3, 2016

I think we could do it by disabling the later fields if an earlier one is entered, however without some sort of visual representation of this I think it just gets more confusing to the user about what's happening

@AbhiAgarwal AbhiAgarwal merged commit a3301d3 into develop Apr 6, 2016
@brentdur brentdur deleted the brenton/add_validation branch April 6, 2016 20:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants