Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core dumped when using the GE20 prescription for critical mass ratios #1022

Closed
nrsegovia opened this issue Dec 11, 2023 · 2 comments · Fixed by #1025
Closed

Core dumped when using the GE20 prescription for critical mass ratios #1022

nrsegovia opened this issue Dec 11, 2023 · 2 comments · Fixed by #1025
Assignees
@jeffriley
Labels
bug Something isn't working severity_minor This bug is not very severe

Comments

@nrsegovia
Copy link
Collaborator

Describe the bug

By using the following configuration on COMPAS v02.39.00

COMPAS --random-seed 15 --quiet TRUE --logfile-definitions gridDefinitions.txt --maximum-evolution-time 13700 --initial-mass-min 0.08  --common-envelope-alpha 1 --grid binaries.txt --rlof-printing TRUE --mass-transfer-accretion-efficiency-prescription FIXED --critical-mass-ratio-prescription GE20 -z 0.03 --mass-transfer-fa 0.5 --mass-transfer-angular-momentum-loss-prescription MACLEOD_LINEAR --mass-transfer-jloss-macleod-linear-fraction 0

I get the following error

terminate called after throwing an instance of 'std::bad_array_new_length'
terminate called recursively
Aborted (core dumped)

which produces rather small files, around 10% of what I expect. The same population under different prescriptions ( "NONE" and "HURLEY_HJELLMING_WEBBINK") works just fine.

To Reproduce
Run COMPAS using the gridfile I have attached and the configuration specified above. The logfile configuration can be ignored, it seems.

Additional context
Jeff was able to reproduce the issue on v2.41.00

gridfile.tar.gz
@nrsegovia nrsegovia added bug Something isn't working severity_minor This bug is not very severe labels Dec 11, 2023
jeffriley added a commit to jeffriley/COMPAS-1 that referenced this issue Dec 11, 2023
@jeffriley
Defect repair:
a07f366 
- Fix for issue TeamCOMPAS#1022 - incorrect value being used for last entry in array in BaseStar::InterpolateGe20QCrit()
@jeffriley jeffriley mentioned this issue Dec 11, 2023
Closed
jeffriley added a commit to jeffriley/COMPAS-1 that referenced this issue Dec 11, 2023
@jeffriley
Fix for issue TeamCOMPAS#1022
9ecda70
jeffriley added a commit to jeffriley/COMPAS-1 that referenced this issue Dec 11, 2023
@jeffriley
Fix for issue TeamCOMPAS#1022
a8516a6
@jeffriley jeffriley mentioned this issue Dec 11, 2023
Merged
@jeffriley jeffriley linked a pull request Dec 11, 2023 that will close this issue
Fix for issue #1022 #1025
Merged
@jeffriley
Copy link
Collaborator

Fixed in v02.41.01
PR #1025

ilyamandel added a commit that referenced this issue Dec 11, 2023
@ilyamandel
Merge pull request #1025 from jeffriley/issue#1022
200b1a1 
Fix for issue #1022
@ilyamandel
Copy link
Collaborator

Fixed by @jeffriley (thank you!), closing, with thanks to @nrsegovia for reporting!

@jeffriley jeffriley mentioned this issue Dec 11, 2023
Merged
reinhold-willcox added a commit that referenced this issue Dec 22, 2023
@reinhold-willcox @jeffriley @ilyamandel
Issue#1022 remerge (#1037)
8d0c9f8 
* Fix for issue #1022

* Code cleanup

---------

Co-authored-by: Jeff Riley <jeff.riley@monash.edu>
Co-authored-by: Ilya Mandel <ilyamandel@users.noreply.github.com>
reinhold-willcox added a commit that referenced this issue Dec 22, 2023
@reinhold-willcox @jeffriley
@ilyamandel @themikelau
Plotter updates remerge (#1038)
6a99c69 
* Fix for issue #1022

* Code cleanup

* Event strings (#1021)

* (compasUtils) bug fix to getSNevents()

* (compasUtils) make getEventHistory() work for COMPAS output with unordered seeds

* (compasUtils) fix typo

* switched to lexsort from argsort to better handle the ordering of multiple events from the same seed

* changed list initialization for np array, changed some variable names for clarity

* changed np array back to list, since array couldn't handle input of different sizes

---------

Co-authored-by: Reinhold Willcox <reinhold.willcox@gmail.com>

* Merge pull request #996 from TeamCOMPAS/updated_winds_fresh

Updated wind perscriptions

* Reapply winds changes from 2.40.00

* fixes to the detailed plotter, including improved robustness to the Roche Lobe, and masking for only end-of-timestep events

* added question to CalculateMassLossRateNieuwenhuijzenDeJager

---------

Co-authored-by: Jeff Riley <jeff.riley@monash.edu>
Co-authored-by: Ilya Mandel <ilyamandel@users.noreply.github.com>
Co-authored-by: Mike Lau <mike.lau@h-its.org>
Co-authored-by: jeffriley <jeffrey.riley@monash.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffriley jeffriley

Labels
bug Something isn't working severity_minor This bug is not very severe
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for issue #1022 jeffriley/COMPAS-1
3 participants
@ilyamandel @jeffriley @nrsegovia