Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #1022 #1025

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Fix for issue #1022 #1025

merged 2 commits into from
Dec 11, 2023

Conversation

jeffriley
Copy link
Collaborator

@jeffriley jeffriley commented Dec 11, 2023 •
edited
Loading

Fix for issue #1022 - an incorrect index was being used for the last entry of an array.

This PR includes two commits: the first contains the fix, the second a little bit of (related) code cleanup.

@jeffriley jeffriley changed the base branch from dev to issue#1022 December 11, 2023 04:44
@jeffriley jeffriley added bug Something isn't working severity_moderate This is a moderately severe bug urgency_moderate This is a moderately urgent issue labels Dec 11, 2023
@jeffriley jeffriley linked an issue Dec 11, 2023 that may be closed by this pull request
Core dumped when using the GE20 prescription for critical mass ratios #1022
Closed
@jeffriley jeffriley requested a review from nrsegovia December 11, 2023 04:48
@jeffriley jeffriley mentioned this pull request Dec 11, 2023
Closed
ilyamandel
ilyamandel approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@ilyamandel ilyamandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the quick fix!

@ilyamandel ilyamandel merged commit 200b1a1 into TeamCOMPAS:issue#1022 Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyamandel ilyamandel ilyamandel approved these changes

@reinhold-willcox reinhold-willcox Awaiting requested review from reinhold-willcox

@nrsegovia nrsegovia Awaiting requested review from nrsegovia

Assignees
No one assigned
Labels
bug Something isn't working severity_moderate This is a moderately severe bug urgency_moderate This is a moderately urgent issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Core dumped when using the GE20 prescription for critical mass ratios
2 participants
@jeffriley @ilyamandel