Retain extra project references when processing a source file #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramen
approved these changes
Jan 28, 2025
Comment on lines
+106
to
+107
| -- do we get a lot of textless segments? thinking emoji | ||
| if s:get('text') then |
There was a problem hiding this comment.
These sorts of things grew from testing different backends and the inconsistencies we saw in the results. I don't remember why it was necessary at this point, but a missing text field is a pretty good check for "is this a segment at all?"
There was a problem hiding this comment.
yeah, i think we've even probably talked about this before. in working on other stuff with actual VO recordings i'm also running into a lot of [_description_] "segments", like [BLANK AUDIO] or [Pause].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, if you ask ReaSpeech to process a collection of tracks/items that sees the same source file more than once, only one of those media item/take references will be retained and added as a transcript segment.
this change retains those extra references, and for each one will add the found segments for a given source file to the transcript. yes, this means that you can have the same text show up multiple times in a transcript. no, i don't think that's weird, it's your weird project, friend!
this also changes the start/end columns in the transcript table to reflect the segment's start/end relative to the full project timeline.
from here i'm picturing what the ux might look like for resolving overlap conflicts. 🤔
Screen.Recording.2025-01-25.at.14.16.11.mov