Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conduit facades #771

Merged
merged 18 commits into from
Dec 30, 2024
Merged

Conduit facades #771

merged 18 commits into from
Dec 30, 2024

Conversation

Rover656
Copy link
Member

@Rover656 Rover656 commented Aug 5, 2024 •
edited
Loading

Description

  • Conduit Facades (normal, transparent, hardened and transparent hardened).
  • Holding any wrench in main hand or offhand hides the facades and allows interaction under the hood.

Deferred for future:

  • Enable/disable this behaviour with shift+scroll on Yeta wrench
  • Allow showing/hiding individual conduit types

Closes #301

TODO

  • Blast resistance increase
  • Ability to place conduit bundle with no conduits (facade only) future work
  • Fix AE2 conduit facade interop
  • Ensure block break interactions are correct
  • Render wireframe (possibly with a BER) when the facades are hidden
  • Fix collision work when hiding facades (should still collide like a full block)
  • Config option for enable/disable conduit facade hiding functionality entirely. cannot be a user preference with how it is designed atm.

Checklist

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@Rover656 Rover656 added Type-Enhancement New feature or enhancement to existing feature. Area-Conduits Everything involving conduits MC-1.21 labels Aug 5, 2024
@Rover656 Rover656 added this to the 1.12.2 Parity Features milestone Aug 5, 2024
@Rover656 Rover656 force-pushed the feat/conduit-facades branch from 4638a57 to 66a275b Compare August 21, 2024 12:39
@turnerlewis
Copy link

You're doing gods work guys!

@Rover656 Rover656 force-pushed the feat/conduit-facades branch from 485b5e8 to 382a8f5 Compare September 29, 2024 00:22
@Rover656 Rover656 changed the base branch from dev/1.21 to dev/1.21.1 September 30, 2024 16:40
@Rover656 Rover656 force-pushed the feat/conduit-facades branch from 382a8f5 to 944fb0f Compare October 12, 2024 17:32
@Rover656 Rover656 force-pushed the feat/conduit-facades branch from 944fb0f to cb31ffd Compare December 23, 2024 02:43
Rover656 and others added 7 commits December 29, 2024 20:59
@Rover656
feat: Initial enablement of facades. Allows a single block type and s…
d062527 
…upports the "transparent" variant (in code). Facades hide when holding a wrench.

Next need to add facade items instead of using the painted slab, handle increased blast resistance and allow facades to be placed without any conduit in the space (for laying down future paths). Also need to handle break interactions.
@Rover656
feat: Added facade items and facade breaking behaviour.
843de7a
@Rover656
chore: Some cleanup and fixed collisions when hiding facades with a w…
9ac7781 
…rench.
@Rover656
fix: Allow placing conduits into an existing bundle when right clicki…
864cade 
…ng the block below
@Rover656
chore: change how facades are stored and tidy up after the rebase.
47e7667 
Conduit items now also hide facades
@Rover656
chore: Working out how we might texture the facades.
0299763 
Currently invisible before painting now.
@ferriarnus @Rover656
reworked facade handeling
d54c01e 
- transparent rendering
- custom item model
- CTM and tint support
- Item models
@Rover656 Rover656 force-pushed the feat/conduit-facades branch from ea6cf4a to d54c01e Compare December 29, 2024 21:19
@Rover656 Rover656 marked this pull request as ready for review December 29, 2024 23:26
@Rover656 Rover656 changed the title [WIP] Conduit facades Conduit facades Dec 29, 2024
@Rover656 Rover656 merged commit 78e6272 into dev/1.21.1 Dec 30, 2024
1 check passed
@Rover656 Rover656 deleted the feat/conduit-facades branch December 30, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenryLoenwind HenryLoenwind HenryLoenwind left review comments

Assignees
No one assigned
Labels
Area-Conduits Everything involving conduits MC-1.21 Type-Enhancement New feature or enhancement to existing feature.
Projects
None yet
Milestone
1.12.2 Parity Features
Development

Successfully merging this pull request may close these issues.

Conduit Facades
4 participants
@Rover656 @turnerlewis @HenryLoenwind @ferriarnus