Add config quick select tokens for deposit/withdrawal forms #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanhpn
force-pushed
the
feat/quick-deposit-tokens
branch
from
d29c142 to
3b24d60
Compare
andrewsoon
requested changes
Dec 17, 2024
configs/mainnet.json
Outdated
Comment on lines
483
to
496
| "show": "brdg/4b90a8d1225d11ed7af0661ff7309714189a527302892cad03ace7615d417d38", | ||
| "real" : "cgt/1" | ||
| }, | ||
| { | ||
| "show": "swth", | ||
| "real" : "swth" | ||
| }, | ||
| { | ||
| "show": "eth.1.2.942d87", | ||
| "real" : "eth.1.2.942d87" | ||
| }, | ||
| { | ||
| "show": "brdg/a02afc2c1edf77cc023eefa25fc036c184612faf9365cda9c1daa3b1675ebf8f", | ||
| "real" : "brdg/a02afc2c1edf77cc023eefa25fc036c184612faf9365cda9c1daa3b1675ebf8f" |
There was a problem hiding this comment.
think its just a matter of label and the actual token selected. modify the field to show the label, add icon_denom to fetch the correct icon and add quick_select_denom to link to the intended token after selecting
would be good to add priority to the fields also so the UI can sort by priority
{
"priority": "1",
"label": "USDC",
"icon_denom": "{any usdc denom that returns the usdc icon}",
"quick_select_denom": "cgt/1",
}, {
...
}
scripts/check_configs.ts
Outdated
Comment on lines
433
to
450
| const duplicateRealTokens = checkDuplicateEntries(quickSelectTokens.map(token => token.real)); | ||
| const invalidRealTokens = checkValidEntries(quickSelectTokens.map(token => token.real), denoms); | ||
|
|
||
| if (duplicateQuickSelectTokens.status && duplicateQuickSelectTokens.entry) { | ||
| let listOfDuplicates: string = duplicateQuickSelectTokens.entry.join(", "); | ||
| console.error(`ERROR: ${network}.json has the following duplicated quick select tokens: ${listOfDuplicates}. Please make sure to input each token only once in ${network}`); | ||
| return false; | ||
| } | ||
|
|
||
| if (invalidQuickSelectTokens.status && invalidQuickSelectTokens.entry) { | ||
| let listOfInvalidTokens: string = invalidQuickSelectTokens.entry.join(", "); | ||
| console.error(`ERROR: ${network}.json has the following invalid quick select token denoms: ${listOfInvalidTokens}. Please make sure to only input valid token denoms in ${network}`); | ||
| return false; | ||
| } | ||
|
|
||
| if (duplicateRealTokens.status && duplicateRealTokens.entry) { | ||
| let listOfDuplicates: string = duplicateRealTokens.entry.join(", "); | ||
| console.error(`ERROR: ${network}.json has the following duplicated real tokens: ${listOfDuplicates}. Please make sure to input each token only once in ${network}`); | ||
| return false; | ||
| } | ||
|
|
||
| if (invalidRealTokens.status && invalidRealTokens.entry) { | ||
| let listOfInvalidTokens: string = invalidRealTokens.entry.join(", "); | ||
| console.error(`ERROR: ${network}.json has the following invalid real token denoms: ${listOfInvalidTokens}. Please make sure to only input valid token denoms in ${network}`); | ||
| return false; |
There was a problem hiding this comment.
i think just need to check if quick_select_denom is a valid token should be sufficient. Different tokens can still point to the same selected token
i.e. USDC, axlUSDC can all point to cgt/1
but do check for duplicate labels e.g. cannot have two USDC buttons appearing
configs/devnet.json
Outdated
Comment on lines
50
to
65
| { | ||
| "show": "swth", | ||
| "real" : "swth" | ||
| }, | ||
| { | ||
| "show": "usdc", | ||
| "real" : "usdc" | ||
| }, | ||
| { | ||
| "show": "eth", | ||
| "real" : "eth" | ||
| }, | ||
| { | ||
| "show": "dai", | ||
| "real" : "dai" | ||
| } |
There was a problem hiding this comment.
update structs based on comments
configs/testnet.json
Outdated
Comment on lines
64
to
79
| { | ||
| "show": "swth", | ||
| "real" : "swth" | ||
| }, | ||
| { | ||
| "show": "usdc", | ||
| "real" : "usdc" | ||
| }, | ||
| { | ||
| "show": "eth", | ||
| "real" : "eth" | ||
| }, | ||
| { | ||
| "show": "dai", | ||
| "real" : "dai" | ||
| } |
There was a problem hiding this comment.
update structs based on comments
.github/markets/pr_template.md
Outdated
Comment on lines
128
to
129
| |`real` |`string` |true |The default token will be use to transfer in deposit/withdrawal | |
There was a problem hiding this comment.
update structs based on comments
config.schema.json
Outdated
Comment on lines
524
to
531
| "show": { | ||
| "type": "string", | ||
| "description": "Token to show on UI" | ||
| }, | ||
| "real": { | ||
| "type": "string", | ||
| "description": "Token to use in transfer" | ||
| } |
There was a problem hiding this comment.
update structs based on comments
thanhpn
force-pushed
the
feat/quick-deposit-tokens
branch
from
33707fa to
b950a0d
Compare
thanhpn
force-pushed
the
feat/quick-deposit-tokens
branch
from
b950a0d to
a836a0e
Compare
andrewsoon
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.