Add typeform survey widget config #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsoon
requested changes
Jul 11, 2024
There was a problem hiding this comment.
Rmb to update the pr_template and readme, can refer to:
https://github.com/Switcheo/demex-webapp-config/pull/159/files
can add the relevant checks in check_configs script e.g. endTime must be later than now, no duplicate pages
be sure to run yarn check-configs and yarn validate to make sure the json and script is added correctly and to test whether the script is validating the entries properly too
configs/mainnet.json
Outdated
Comment on lines
222
to
229
| "typeform_widget_config": { | ||
| "surveyLink": "https://switcheonetwork.typeform.com/to/C1rheplK", | ||
| "endTime": "2024-07-26T23:00:00Z", | ||
| "pages": [ | ||
| "/account/overview", | ||
| "/account/balance" | ||
| ] | ||
| } |
There was a problem hiding this comment.
this only allows one survey to be ongoing at one time, it should be a map/array of survey params instead so that we can support multiple survey forms
andrewsoon
reviewed
Jul 12, 2024
.github/markets/pr_template.md
Outdated
| @@ -17,7 +17,7 @@ Each json file under the [configs](../../configs) folder correspond to their res | |||
| |`demex_points_config` |`DemexPointsConfig` |false |Object that contains the parameters to earn demex points. |This object **must be included** for mainnet.json as demex points is already live on mainnet. | | |||
| |`perp_pool_promo` |`PerpPoolPromo` |false |Map of Objects that contains perp pool promo parameters for each pool |If the `perp_pool_promo` property is omitted, no promo will be shown. The key of each entry is the ids of the perp pools with existing promo. | | |||
| |`cross_selling_source_tokens` |`string[]` |true |The array of cross selling source tokens. Acquiring these tokens on the spot market will trigger a help wizard, prompting users to borrow USDG and trade perps on Demex. |The token denoms listed here **MUST** match the token denoms listed under the Carbon [Tokens API](https://api.carbon.network/carbon/coin/v1/tokens?pagination.limit=10000). | | |||
|
|
|||
| |`typeform_widget_config` |`TypeformWidgetConfig` |false |Object that contains the parameters for ongoing surveys. | If the `message` property is omitted, default message is shown: "We want to hear from you!". Multiple widgets being displayed on the same page is not supported. Ensure pages don't overlap between configs. | | |||
There was a problem hiding this comment.
should the type be TypeformWidgetConfig[] instead?
andrewsoon
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.