✨ [STMT-200] 스터디 수정 api 구현 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 내부 클래스로 선언하는 이점이 없다고 생각하여 분리하였습니다.
zxcv9203
reviewed
Apr 13, 2024
src/main/java/com/stumeet/server/study/adapter/out/persistance/entity/StudyJpaEntity.java
Show resolved
Hide resolved
.../java/com/stumeet/server/study/adapter/out/persistance/mapper/StudyTagPersistenceMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/com/stumeet/server/study/application/port/in/command/StudyUpdateCommand.java
Outdated
Show resolved
Hide resolved
구현할 때는 어쩔 수 없이 null을 사용해야 하는 부분이라고 생각했는데 지금 보니 잘못 아는 것들이 존재했던 것 같습니다. 리뷰 달아주신 내용에 대해서 내일 반영하여 다시 요청 드리겠습니다~! 👍 |
: 현재 사용되고 있는 modelAttribute에서 Multipart file과 다른 파라미터 값이 혼용되어 있는 객체에서 multiform data 요청은 빈 배열을 받지 못하고 해당 파라미터의 값을 null로 인식하였습니다. 따라서 파일과 요청본문을 request part로 분리하여 파라미터 값으로 빈 문자열도 받을 수 있도록 리팩토링 하였습니다.
해당 사항 반영하였습니다! 재검토 부탁 드립니다! |
zxcv9203
approved these changes
Apr 16, 2024
src/main/java/com/stumeet/server/study/adapter/out/persistance/entity/StudyJpaEntity.java
Show resolved
Hide resolved
src/test/java/com/stumeet/server/study/adapter/in/web/StudyCreateApiTest.java
Show resolved
Hide resolved
src/test/java/com/stumeet/server/study/adapter/in/web/StudyUpdateApiTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 어떤 방식으로 해결했는지 적어주세요