Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup, Swift 6, Consent Contraint and SignatureView improvements #60

Merged
merged 26 commits into from
Jan 29, 2025

Final improvements

bfb2528
Select commit
Loading
Failed to load commit list.
Merged

Cleanup, Swift 6, Consent Contraint and SignatureView improvements #60

Final improvements
bfb2528
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 29, 2025 in 0s

73.80% (+2.75%) compared to e3b8d50

View this Pull Request on Codecov

73.80% (+2.75%) compared to e3b8d50

Details

Codecov Report

Attention: Patch coverage is 74.75000% with 101 lines in your changes missing coverage. Please review.

Project coverage is 73.80%. Comparing base (e3b8d50) to head (bfb2528).

Files with missing lines Patch % Lines
...ources/SpeziOnboarding/OnboardingConsentView.swift 41.18% 40 Missing ⚠️
.../SpeziOnboarding/Consent/Views/SignatureView.swift 44.12% 19 Missing ⚠️
...ng/Consent/Views/OnboardingConsentView+Error.swift 0.00% 18 Missing ⚠️
...peziOnboarding/Consent/Views/ConsentDocument.swift 83.02% 9 Missing ⚠️
...arding/Consent/Export/ConsentDocument+Export.swift 82.50% 7 Missing ⚠️
...arding/Consent/Views/SignatureViewBackground.swift 87.04% 7 Missing ⚠️
...t/ConsentDocumentExportRepresentation+Render.swift 99.10% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   71.06%   73.80%   +2.75%     
==========================================
  Files          27       24       -3     
  Lines        1323     1328       +5     
==========================================
+ Hits          940      980      +40     
+ Misses        383      348      -35
Files with missing lines Coverage Δ
...iOnboarding/Consent/ConsentViewState+Binding.swift 100.00% <ø> (ø)
...ntDocumentExportRepresentation+Configuration.swift 65.00% <100.00%> (ø)
...t/Export/ConsentDocumentExportRepresentation.swift 100.00% <100.00%> (ø)
...nsent/Views/OnboardingConsentView+ShareSheet.swift 0.00% <ø> (ø)
...ing/OnboardingFlow/IllegalOnboardingStepView.swift 0.00% <ø> (ø)
...rdingFlow/OnboardingIdentifiableViewModifier.swift 100.00% <ø> (ø)
...eziOnboarding/OnboardingFlow/OnboardingStack.swift 100.00% <ø> (ø)
...es/SpeziOnboarding/OnboardingInformationView.swift 87.24% <ø> (+37.24%) ⬆️
Sources/SpeziOnboarding/OnboardingView.swift 58.58% <ø> (ø)
...t/ConsentDocumentExportRepresentation+Render.swift 99.10% <99.10%> (ø)
... and 6 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3b8d50...bfb2528. Read the comment docs.

View more details on Codecov