Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessagesAction Update to also handle non-actionable messages without failing #168

Merged
merged 17 commits into from
Feb 7, 2025

add unit test for message item dismissed action

db62fcc
Select commit
Loading
Failed to load commit list.
Merged

MessagesAction Update to also handle non-actionable messages without failing #168

add unit test for message item dismissed action
db62fcc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 7, 2025 in 0s

40.76% (-0.03%) compared to e32d00a

View this Pull Request on Codecov

40.76% (-0.03%) compared to e32d00a

Details

Codecov Report

Attention: Patch coverage is 49.50495% with 102 lines in your changes missing coverage. Please review.

Project coverage is 40.76%. Comparing base (e32d00a) to head (db62fcc).

Files with missing lines Patch % Lines
.../edu/stanford/bdh/engagehf/messages/MessageItem.kt 0.00% 56 Missing ⚠️
...u/stanford/bdh/engagehf/bluetooth/HomeViewModel.kt 68.75% 8 Missing and 7 partials ⚠️
...ford/bdh/engagehf/bluetooth/data/models/UiState.kt 55.56% 8 Missing ⚠️
.../stanford/bdh/engagehf/messages/MessagesHandler.kt 69.24% 4 Missing and 4 partials ⚠️
...du/stanford/bdh/engagehf/messages/MessageAction.kt 22.23% 7 Missing ⚠️
...anford/bdh/engagehf/bluetooth/screen/HomeScreen.kt 0.00% 6 Missing ⚠️
...edu/stanford/bdh/engagehf/MainActivityViewModel.kt 75.00% 0 Missing and 1 partial ⚠️
...agehf/bluetooth/data/mapper/MessageActionMapper.kt 90.91% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #168      +/-   ##
============================================
- Coverage     40.80%   40.76%   -0.03%     
- Complexity      866      867       +1     
============================================
  Files           299      299              
  Lines         11514    11553      +39     
  Branches       1736     1752      +16     
============================================
+ Hits           4697     4709      +12     
- Misses         6352     6373      +21     
- Partials        465      471       +6
Files with missing lines Coverage Δ
...nford/bdh/engagehf/bluetooth/data/models/Action.kt 100.00% <100.00%> (ø)
.../bottomsheet/AddBloodPressureBottomSheetUiState.kt 93.55% <ø> (ø)
.../bdh/engagehf/medication/ui/MedicationViewModel.kt 77.15% <100.00%> (ø)
...rd/bdh/engagehf/messages/FirestoreMessageMapper.kt 57.90% <100.00%> (+0.76%) ⬆️
...tlin/edu/stanford/bdh/engagehf/messages/Message.kt 100.00% <100.00%> (+43.91%) ⬆️
...tanford/bdh/engagehf/messages/MessageRepository.kt 79.25% <100.00%> (ø)
...edu/stanford/bdh/engagehf/MainActivityViewModel.kt 96.62% <75.00%> (-1.75%) ⬇️
...agehf/bluetooth/data/mapper/MessageActionMapper.kt 96.00% <90.91%> (ø)
...anford/bdh/engagehf/bluetooth/screen/HomeScreen.kt 0.00% <0.00%> (ø)
...du/stanford/bdh/engagehf/messages/MessageAction.kt 22.23% <22.23%> (ø)
... and 4 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e32d00a...db62fcc. Read the comment docs.

View more details on Codecov