Pull Request

Detekt #24

Sign in to view logs

Triggered via pull request May 28, 2024 18:22

eldcn

synchronize #18

task/detekt

Status Cancelled

Total duration 3m 53s

Artifacts –

pull_request.yml

on: pull_request

Annotations

2 errors and 7 warnings

Build and test

Canceling since a higher priority waiting request for 'build-refs/pull/18/merge' exists

Build and test

The operation was canceled.

[detekt] core/coroutines/src/main/kotlin/edu/stanford/spezi/core/coroutines/di/CoroutinesModule.kt#L25 <detekt.NoConsecutiveBlankLines>: core/coroutines/src/main/kotlin/edu/stanford/spezi/core/coroutines/di/CoroutinesModule.kt#L25

Needless blank line(s)

[detekt] core/coroutines/src/main/kotlin/edu/stanford/spezi/core/coroutines/di/CoroutinesModule.kt#L28 <detekt.NoMultipleSpaces>: core/coroutines/src/main/kotlin/edu/stanford/spezi/core/coroutines/di/CoroutinesModule.kt#L28

Unnecessary long whitespace

[detekt] core/coroutines/src/main/kotlin/edu/stanford/spezi/core/coroutines/di/CoroutinesModule.kt#L28 <detekt.VariableNaming>: core/coroutines/src/main/kotlin/edu/stanford/spezi/core/coroutines/di/CoroutinesModule.kt#L28

Variable names should match the pattern: [a-z][A-Za-z0-9]*

[detekt] core/coroutines/src/main/kotlin/edu/stanford/spezi/core/coroutines/di/CoroutinesModule.kt#L27 <detekt.ForbiddenComment>: core/coroutines/src/main/kotlin/edu/stanford/spezi/core/coroutines/di/CoroutinesModule.kt#L27

This comment contains 'FIXME:' that has been defined as forbidden.

[detekt] core/coroutines/src/main/kotlin/edu/stanford/spezi/core/coroutines/di/CoroutinesModule.kt#L28 <detekt.MagicNumber>: core/coroutines/src/main/kotlin/edu/stanford/spezi/core/coroutines/di/CoroutinesModule.kt#L28

This expression contains a magic number. Consider defining it to a well named constant.

Detekt review

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Detekt review

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/