Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S7141(secrets): Chief Tools API tokens should not be disclosed (APPSEC-2232) #4471

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 5, 2024

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@loris-s-sonarsource loris-s-sonarsource changed the title Create rule S7141 Create rule S7141(secrets): Chief Tools API tokens should not be disclosed Nov 6, 2024
@loris-s-sonarsource loris-s-sonarsource marked this pull request as ready for review November 6, 2024 10:18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should remove the "pornographic material" part. There is no need to be so explicit. "Unsolicited or inappropriate content" seems enough.
Also, you should consider reusing the phishing.adoc that cover the exact same risk.

Comment on lines 33 to 42
==== Phishing and spam
I the leaked secret gives an attacker a Tny entitlement, an attacker can use
this API token to hide a malicious domain and use it in spam/phishing campaigns.

Spam can cause users to be exposed to the following:

* Unsolicited, inappropriate content, such as pornographic material
* Fraudulent attempts to trick users into sending information or money
* Abusive or hateful statements
* False advertising or fraudulent claims

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered reusing the phishing.adoc here?
Although I agree its possible, I think mentioning pornographic material explicitly is not necessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I considered using this file, I copied from it. The context is not the same, so I just copied and pasted its list of risks

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I did not read the phishing. doc file entirely and did not notice the list of risks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's alright, no worries

Copy link

sonarqube-next bot commented Nov 7, 2024

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

sonarqube-next bot commented Nov 7, 2024

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource merged commit 3763add into master Nov 7, 2024
9 of 10 checks passed
@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource deleted the rule/add-RSPEC-S7141 branch November 7, 2024 13:55
@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource changed the title Create rule S7141(secrets): Chief Tools API tokens should not be disclosed Create rule S7141(secrets): Chief Tools API tokens should not be disclosed (APPSEC-2232) Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants