-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create rule S7141(secrets): Chief Tools API tokens should not be disclosed (APPSEC-2232) #4471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should remove the "pornographic material" part. There is no need to be so explicit. "Unsolicited or inappropriate content" seems enough.
Also, you should consider reusing the phishing.adoc
that cover the exact same risk.
rules/S7141/secrets/rule.adoc
Outdated
==== Phishing and spam | ||
I the leaked secret gives an attacker a Tny entitlement, an attacker can use | ||
this API token to hide a malicious domain and use it in spam/phishing campaigns. | ||
|
||
Spam can cause users to be exposed to the following: | ||
|
||
* Unsolicited, inappropriate content, such as pornographic material | ||
* Fraudulent attempts to trick users into sending information or money | ||
* Abusive or hateful statements | ||
* False advertising or fraudulent claims |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered reusing the phishing.adoc
here?
Although I agree its possible, I think mentioning pornographic material explicitly is not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I considered using this file, I copied from it. The context is not the same, so I just copied and pasted its list of risks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry. I did not read the phishing. doc
file entirely and did not notice the list of risks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's alright, no worries
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3763add
into
master
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: