check if health check already exist in the queue #156
+52
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frikky
reviewed
Mar 4, 2025
health.go
Outdated
| @@ -429,6 +429,51 @@ func deleteJunkOpsWorkflow(ctx context.Context, workflowHealth WorkflowHealth) e | |||
| return nil | |||
| } | |||
|
|
|||
| func checkQueueForHealthRun(ctx context.Context) error{ | |||
| baseUrl := "https://shuffler.io" | |||
| if os.Getenv("SHUFFLE_CLOUDRUN_URL") != "" { | |||
There was a problem hiding this comment.
Just always check BASE_URL > CLOUDRUN_URL, as CLOUDRUN_URL is the override we use everywhere
health.go
Outdated
| baseUrl = os.Getenv("SHUFFLE_CLOUDRUN_URL") | ||
| } | ||
|
|
||
| if project.Environment == "onprem" { |
There was a problem hiding this comment.
This may be wrong, so instead of == "onprem" do != "cloud"
health.go
Outdated
|
|
||
|
|
||
| client := GetExternalClient(baseUrl) | ||
| fullUrl := fmt.Sprintf("%s/api/v1/workflows/queue", baseUrl) |
There was a problem hiding this comment.
Can't you read this directly from the database? Using the API seems silly lol.
| @@ -565,6 +610,41 @@ func RunOpsHealthCheck(resp http.ResponseWriter, request *http.Request) { | |||
| } | |||
| } else { | |||
| // FIXME: Add a check for if it's been <interval> length at least between runs. This is 15 minutes by default. | |||
| err := checkQueueForHealthRun(ctx) | |||
| if err != nil { | |||
| log.Printf("[ERROR] Failed running health check (4): %s", err) | |||
There was a problem hiding this comment.
Shouldn't this then fail out? Why are we not handling the error?
|
ready for round 2 of review @frikky :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.