Create media session UI and fix player notification #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it introduces MediaSessionPlayerUi, moving more code out of the Player, and fixes various serious issues related to the player notification and the media session. I tried to put as much info as possible in commit messages and comments, so that it is simpler to debug and git blame.
Some useless classes were removed
MediaSessionCallback and PlayerMediaSession was just a wrapper for some player functions (half of which used in one place, half in another), but it didn't make any sense not to use the player instance directly bca9543
All of MediaSessionManager was moved in MediaSessionPlayerUi
Co-Authored-By: Stypox <stypox@pm.me>
Co-Authored-By: Stypox <stypox@pm.me>
Co-Authored-By: Stypox <stypox@pm.me>
Co-Authored-By: Stypox <stypox@pm.me>
Co-Authored-By: Stypox <stypox@pm.me>
Co-Authored-By: Stypox <stypox@pm.me>
fix channel content not loading giving parsing exception could not load channel id
…eams Some services may only have video streams and no separate audio streams available. This commit will add audio background playback support for those services. It uses the video source as audio source for background playback. Co-Authored-By: evermind-zz <55653+evermind-zz@users.noreply.github.com>
Co-Authored-By: evermind-zz <55653+evermind-zz@users.noreply.github.com>
Repository owner
deleted a comment from
Baltazar500
Jul 20, 2024
Repository owner
deleted a comment from
Baltazar500
Jul 20, 2024
Repository owner
locked and limited conversation to collaborators
Jul 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
it introduces MediaSessionPlayerUi, moving more code out of the Player, and fixes various serious issues related to the player notification and the media session. I tried to put as much info as possible in commit messages and comments, so that it is simpler to debug and git blame.
Some useless classes were removed
MediaSessionCallback and PlayerMediaSession was just a wrapper for some player functions (half of which used in one place, half in another), but it didn't make any sense not to use the player instance directly bca9543
All of MediaSessionManager was moved in MediaSessionPlayerUi
Testing apk
debug.zip
Agreement