Skip to content

Update PR template and remove duplicates in release procedure #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented May 6, 2025

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

For some reason there's duplicated steps in the release procedure.

2. Jira task / GitHub issue

Is this a GitHub issue? --> Add the link to the github issue

Is this from a Jira task? --> If your branch does not contain info regarding the Jira task ID, put it here.

3. Type of change - Add label

What type of change(s) does the PR contain? For an explanation of the different options below, enter edit mode of this PR description template.

  • type: breaking: Changes in this PR will cause existing functionality to not work as expected. The master branch of the API will no longer work with the CLI dev branch (and vice versa).
  • type: feature: You've added new functionality or updated an existing one.
  • type: bug: The PR fixes a bug.
  • type: docs: The PR only updates documentation.
  • type: dependency: You've updated a dependency version, e.g. a python package (in requirements.txt).
  • skip-changelog: None of the above mentioned labels fit in. E.g. a new GitHub Action, a PR containing only tests, etc.

4. Additional information

5. Actions / Scans

Make sure that the following checks/actions have passed.

  • Black
  • Prettier
  • Pylint
  • Yamllint
  • Tests
  • CodeQL
  • Trivy
  • Snyk
  • TestPyPI

If an action does not pass and you need help with how to solve it, enter edit mode of this PR template or go to the PR template.

@i-oden i-oden self-assigned this May 6, 2025
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.65%. Comparing base (d687ba4) to head (d375606).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #756   +/-   ##
=======================================
  Coverage   47.65%   47.65%           
=======================================
  Files          31       31           
  Lines        2925     2925           
=======================================
  Hits         1394     1394           
  Misses       1531     1531           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@i-oden i-oden changed the title update pr template and remove duplicate text in release procedure Update PR template and remove duplicates in release procedure May 7, 2025
@i-oden i-oden added the skip-changelog For release template label May 7, 2025
@i-oden i-oden marked this pull request as ready for review May 7, 2025 06:52
@i-oden i-oden requested a review from a team as a code owner May 7, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog For release template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant