Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test FastGaussQuadrature and Arblib #216

Merged
merged 13 commits into from
Jan 10, 2024
Merged

Conversation

lxvm
Copy link
Collaborator

@lxvm lxvm commented Jan 3, 2024

Fixes #150

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Just adding more tests where applicable

@lxvm lxvm changed the title Test FastGaussQuadurature and Arblib Test FastGaussQuadrature and Arblib Jan 3, 2024
@lxvm lxvm requested a review from agerlach January 3, 2024 20:33
@lxvm
Copy link
Collaborator Author

lxvm commented Jan 9, 2024

@agerlach I fixed a few issues and this pr should be ready to go.

The only significant, yet non-breaking change I had to make was to pass arbitrary keywords to the new VEGASMC algorithm so that I could seed the rng to pass the tests. Since that package has a somewhat complicated configuration, I think that was the best I could do while keeping reasonable, generic defaults. This also gives users access to all of that packages' features, like configuring assumptions about each variable of integration separately.

Also, we could reduce maintenance effort by moving test/gaussian_quadrature_tests.jl and test/quadrule_tests.jl to test/interface_tests.jl since they now overlap due to this pr. However, I think this could be combined with deprecating the GaussLegendre algorithm for a QuadratureRule(gausslegendre), so I'll leave it to a future pr.

@ChrisRackauckas ChrisRackauckas merged commit bae0084 into SciML:master Jan 10, 2024
6 of 8 checks passed
@lxvm lxvm deleted the adfastgauss branch January 10, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests FastGaussQuadrature + AD
2 participants