W-17609247 - Fix Safari bug where the same image loads several times #2223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a known Safari bug seen also in other systems (such as this from Next.js).
The bug in Safari is that if an image has the
src
attribute beforesrcSet
andsizes
, it will fetch the image multiple times as it processes each attribute.To ensure Safari only loads an image once, we set
src
to be the last attribute.Reproducing the original issue:
?sw={width}&q=60
)You can compare this result with Chrome (which only loads the image once with
?sw={width}&q=60
)Testing the fix:
?sw={width}&q=60
)