Support Node 22 (@W-17518271@) #2218
Conversation
joeluong-sfcc
added
skip changelog
Signed-off-by: Joel Uong <88680517+joeluong-sfcc@users.noreply.github.com>
Signed-off-by: Joel Uong <88680517+joeluong-sfcc@users.noreply.github.com>
| - node: 16 | ||
| npm: 11 | ||
| - node: 18 | ||
| npm: 11 |
There was a problem hiding this comment.
Cool, thanks for adding these excludes.
| # The current recommended version for Managed Runtime: | ||
| # https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/upgrade-node-version.html | ||
| IS_MRT_NODE: ${{ matrix.node == 20 && matrix.npm == 10 }} | ||
| IS_MRT_NODE: ${{ matrix.node == 22 && matrix.npm == 10 }} |
There was a problem hiding this comment.
Can you confirm the Node 22 is already out and supported on production mrt? If not, then I believe this should stay at the older Node 20.
There was a problem hiding this comment.
Yeah, production mrt does not currently support Node 22 yet. When I push a bundle, I got this error:
info: Beginning upload to https://cloud.mobify.com
error: HTTP 400
SSRFunctionNodeVersion: Value 22.x is not one of 18.x, 20.x
For more information visit https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/pushing-and-deploying-bundles.html
There was a problem hiding this comment.
Node 22 should be supported on product MRT soon, let me double check the timeline.
There was a problem hiding this comment.
Node 22 support tentatively lands January 31st, 2025 in MRT production
There was a problem hiding this comment.
This is resolved now, node 22 launched last night and I smoke-tested joel's node 22 bundle here
https://scaffold-pwa-joel-test-env.mobify-storefront.com/global/en-GB/category/mens-accessories-ties
| @@ -10,7 +10,7 @@ const config = { | |||
| require('@babel/preset-env'), | |||
| { | |||
| targets: { | |||
| node: 18 | |||
| node: 22 | |||
There was a problem hiding this comment.
Good catch, it looks like this did not get updated last time.
Signed-off-by: Joel Uong <88680517+joeluong-sfcc@users.noreply.github.com>
This PR adds support for node 22 and npm 11.
There are follow up tickets already created for the following work:
Deployed storefront on MRT test environment on node 22 can be found here: https://joel-test-env-production.mobify-storefront-staging.com/
Description
Types of Changes
Changes
How to Test-Drive This PR
Smoke test deployed storefront using node 22 on MRT: https://joel-test-env-production.mobify-storefront-staging.com/
OR
Test locally
git checkout ju/support-node-22npm citemplate-retail-react-appand smoke test./packages/pwa-kit-create-app/scripts/create-mobify-app-dev.jsand smoke test generated projectChecklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization